Set complete marking on nodes created by ricecooker#3410
Merged
rtibbles merged 3 commits intolearningequality:unstablefrom Jul 28, 2022
Merged
Set complete marking on nodes created by ricecooker#3410rtibbles merged 3 commits intolearningequality:unstablefrom
rtibbles merged 3 commits intolearningequality:unstablefrom
Conversation
bjester
approved these changes
Jul 14, 2022
Report incomplete chef nodes on sentry, but do not mark as incomplete yet.
This was referenced Sep 15, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
mark_completemethod for ContentNodemark_incompletemanagement commandReferences
Fixes #2806
Comments
Not entirely sure how we should audit this - we definitely had some issues with the mark_incomplete management command when we ran it on historic data - but I don't have a strong sense of how much of that was affecting cheffed channels.