Edit modal - add additional fields to "Basic info" section#3370
Merged
rtibbles merged 18 commits intolearningequality:unstablefrom Apr 28, 2022
Merged
Edit modal - add additional fields to "Basic info" section#3370rtibbles merged 18 commits intolearningequality:unstablefrom
rtibbles merged 18 commits intolearningequality:unstablefrom
Conversation
This was referenced Apr 18, 2022
5b35db1 to
13b58ab
Compare
rtibbles
reviewed
Apr 25, 2022
Member
rtibbles
left a comment
There was a problem hiding this comment.
A couple of things that could be tweaked, but nothing alarming. I have not yet manually tested.
contentcuration/contentcuration/frontend/channelEdit/components/edit/ResourcesNeededOptions.vue
Outdated
Show resolved
Hide resolved
...ntentcuration/frontend/channelEdit/components/edit/__tests__/learningActivityOptions.spec.js
Show resolved
Hide resolved
...uration/contentcuration/frontend/channelEdit/components/edit/__tests__/levelsOptions.spec.js
Show resolved
Hide resolved
...ontentcuration/frontend/channelEdit/components/edit/__tests__/resourcesNeededOptions.spec.js
Show resolved
Hide resolved
13b58ab to
d6a0d94
Compare
17 tasks
rtibbles
reviewed
Apr 26, 2022
| return Object.entries(ContentLevels).map(level => { | ||
| let translationKey; | ||
| if (level[0] === 'PROFESSIONAL') { | ||
| translationKey = 'specializedProfessionalTraining'; |
Member
There was a problem hiding this comment.
cc @marcellamaki we might want to consolidate this logic somewhere like I think we did on Kolibri?
Contributor
Author
There was a problem hiding this comment.
I think I stole that from Kolibri: https://github.com/learningequality/kolibri/blob/develop/kolibri/plugins/learn/assets/src/views/EmbeddedSidePanel/SelectGroup.vue#L139
rtibbles
requested changes
Apr 26, 2022
Member
rtibbles
left a comment
There was a problem hiding this comment.
Test could still do more guarantee of behaviour.
contentcuration/contentcuration/frontend/channelEdit/components/edit/ResourcesNeededOptions.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/components/edit/ResourcesNeededOptions.vue
Outdated
Show resolved
Hide resolved
...uration/contentcuration/frontend/channelEdit/components/edit/__tests__/levelsOptions.spec.js
Outdated
Show resolved
Hide resolved
rtibbles
approved these changes
Apr 28, 2022
This was referenced Sep 15, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Note, this PR does not cover the "Categories" field, and the following issues are to address some specifics with regards to the "Learning Activity" dropdown field and setting defaults based on content kind, which is not covered in this PR.
DetailsTabView: Set default values on file upload #3373learning_activitiesfield: Data migration needed for historic data in backend #3374Manual verification steps performed
In the edit modal:
Screenshots
Does this introduce any tech-debt items?
This is a continuation of this issue #3205
Reviewer guidance
How can a reviewer test these changes? Please see Gherkin scenarios for additional, specific user interactions
In the edit modal:
References
Comments
Contributor's Checklist
Studio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)