consolidated StudioTestCase and BaseTestCase

[ozer550]

Summary

Consolidated StudioTestCase with BaseTestCase

Reviewer guidance

All test should pass.

Are there any risky areas that deserve extra testing?

References

closes #1076

Comments

---

Contributor's Checklist

PR process:

• If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
• If this includes an internal dependency change, a link to the diff is provided
• The docs label has been added if this introduces a change that needs to be updated in the user docs?
• If any Python requirements have changed, the updated requirements.txt files also included in this PR
• Opportunities for using Google Analytics here are noted
• Migrations are safe for a large db

Studio-specifc:

• All user-facing strings are translated properly
• The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
• All UI components are LTR and RTL compliant
• Views are organized into pages, components, and layouts directories as described in the docs
• Users' storage used is recalculated properly on any changes to main tree files
• If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

• Code is clean and well-commented
• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Any new interactions have been added to the QA Sheet
• Critical and brittle code paths are covered by unit tests

---

Reviewer's Checklist

This section is for reviewers to fill out.

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

Co-authored-by: Vivek Agrawal vivekmittalagrawal@gmail.com
@vkWeb

[vkWeb]

@bjester @ozer550 the failing test case has been fixed by first deleting all the test data files.

Ready to merge @bjester.

[bjester]

The setUp method of a test case runs before every test case method. The code moved into the StudioTestCase.setUp creates a few test fixtures such as a new channel with a tree structure of multiple nodes and a user added as an editor. It's worth considering the impact of how many times that will run in our test suite after this change, so I would like to request some benchmarks from timing the entire test suite before and after this change. There are about 23 test cases using this test case that will now have these fixtures created when they won't be used, and could end up slowing down the test suite.

In the spirit of the original issue, I'm also curious if those BaseTestCase instances should use the StudioAPITestCase instead, seeing as in this change we moved two identical methods that exist in StudioAPITestCase. That might require further tweaks

[ozer550]

Hi @bjester sir, I have tried to delegate the functionality of StudioTestCase and BaseTestCase SetUp method into two different functions so that we do not need to create fixtures again and again.

[bjester]

Great! Thanks for conditionalizing the fixture generation