Import constants from le-utils and add metadata translation mixin#3342
Merged
rtibbles merged 3 commits intolearningequality:unstablefrom Mar 29, 2022
Merged
Conversation
sairina
reviewed
Mar 16, 2022
sairina
approved these changes
Mar 28, 2022
Contributor
sairina
left a comment
There was a problem hiding this comment.
lgtm! If we need to add/update more in the future, we have this as the foundational work to use. Thank you so much!
rtibbles
approved these changes
Mar 29, 2022
This was referenced Sep 15, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Imports the metadata constants from
le-utilsand adds the strings from metadata that were used in kolibri.Manual verification steps performed
Referenced both the constants and some strings to make sure they were available in vue files and was able to access both.
Does this introduce any tech-debt items?
Does adding this in the existing translation mixin file make sense, or would it be better to create a separate file for this? (Originally I added it separately, but then I thought that might be more confusing, if it was the only thing that was handled differently).
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)