Skip to content

fix: override exported content nodes duration to completion criteria threshold#3337

Merged
bjester merged 6 commits intolearningequality:unstablefrom
vkWeb:override-export-duration
Mar 21, 2022
Merged

fix: override exported content nodes duration to completion criteria threshold#3337
bjester merged 6 commits intolearningequality:unstablefrom
vkWeb:override-export-duration

Conversation

@vkWeb
Copy link
Copy Markdown
Member

@vkWeb vkWeb commented Mar 11, 2022

Summary

When a node's completion criteria has a model of either time or approx_time, the exported ContentNode created during channel publishing is set to have the threshold written to the duration field.

Reviewer guidance

Does this PR performs the expected overriding behaviour?

References

Closes #3322.

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@vkWeb vkWeb requested a review from bjester March 11, 2022 19:31
Copy link
Copy Markdown
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small tweaks, looking good

@bjester bjester self-requested a review March 11, 2022 20:48
@bjester
Copy link
Copy Markdown
Member

bjester commented Mar 11, 2022

Looks like the python tests stalled again. Rebasing after #3334 is merged should hopefully help

@bjester bjester merged commit e8a6517 into learningequality:unstable Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Override exported content node duration with completion criteria duration

2 participants