Upgrade celery and use database backend for task results#3332
Merged
rtibbles merged 6 commits intolearningequality:unstablefrom Aug 3, 2022
Merged
Upgrade celery and use database backend for task results#3332rtibbles merged 6 commits intolearningequality:unstablefrom
rtibbles merged 6 commits intolearningequality:unstablefrom
Conversation
This was
linked to
issues
Mar 2, 2022
rtibbles
reviewed
Aug 2, 2022
Member
rtibbles
left a comment
There was a problem hiding this comment.
Looking good - one thing that seems like it might be a blocker from the read through, another that could do with some cleanup.
Member
|
Looks like we need to remove the |
rtibbles
reviewed
Aug 3, 2022
Member
rtibbles
left a comment
There was a problem hiding this comment.
Comments addressed and manual testing checks out. Just cleaning up the celery dashboard seems like the last TODO!
This was referenced Sep 15, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
celeryavailable for Python 3.6Taskmodel and usesTaskResultfromdjango-celery-results, which means this switches the celery result backend from redis to postgresManual verification steps performed
Reviewer guidance
How can a reviewer test these changes?
Are there any risky areas that deserve extra testing?
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)