Skip to content

Draggable resize#3330

Merged
bjester merged 2 commits intolearningequality:unstablefrom
d0sadata:draggable-resize
Mar 9, 2022
Merged

Draggable resize#3330
bjester merged 2 commits intolearningequality:unstablefrom
d0sadata:draggable-resize

Conversation

@d0sadata
Copy link
Copy Markdown
Contributor

@d0sadata d0sadata commented Mar 1, 2022

Summary

Description of the change(s) you made

I've implemented a reduced cursor as to not confuse the user

Manual verification steps performed

  1. Tested on english, it works now as Blaine suggester, On Arabic there is an issue.
  2. Step 2
  3. ...

Does this introduce any tech-debt items?

We need to clear the LTR issues with the clipboard but those are complex and need a different PR


Reviewer guidance

How can a reviewer test these changes?

Open Studio, go to a Channel, copy something to the clipboard with at least 2 levels, and mouseover the part infront of the checkbox

Comments

This is a solution that is suggested by the comment.
My other course of action was moving the padding to the child component of List_node but the issue is that the child component is created by Vuetify ?. I think. it requires to be fixed proper to make the entire row draggable again.
That would require extensive right to left language fixes as well.

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Resolves #3183

@d0sadata d0sadata requested review from bjester and marcellamaki March 1, 2022 15:30
@d0sadata d0sadata self-assigned this Mar 1, 2022
Copy link
Copy Markdown
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it works!

@bjester bjester merged commit 8936b51 into learningequality:unstable Mar 9, 2022
@d0sadata d0sadata deleted the draggable-resize branch April 1, 2022 06:50
@d0sadata d0sadata removed their assignment Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missleading dragable area of the nodes in the clipboard

2 participants