Draggable resize#3330
Merged
bjester merged 2 commits intolearningequality:unstablefrom Mar 9, 2022
d0sadata:draggable-resize
Merged
Draggable resize#3330bjester merged 2 commits intolearningequality:unstablefrom d0sadata:draggable-resize
bjester merged 2 commits intolearningequality:unstablefrom
d0sadata:draggable-resize
Conversation
This was referenced Sep 15, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
I've implemented a reduced cursor as to not confuse the user
Manual verification steps performed
Does this introduce any tech-debt items?
We need to clear the LTR issues with the clipboard but those are complex and need a different PR
Reviewer guidance
How can a reviewer test these changes?
Open Studio, go to a Channel, copy something to the clipboard with at least 2 levels, and mouseover the part infront of the checkbox
Comments
This is a solution that is suggested by the comment.
My other course of action was moving the padding to the child component of List_node but the issue is that the child component is created by Vuetify ?. I think. it requires to be fixed proper to make the entire row draggable again.
That would require extensive right to left language fixes as well.
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)Resolves #3183