Skip to content

Support adding completion criteria and validating its structure#3318

Merged
rtibbles merged 9 commits intolearningequality:unstablefrom
bjester:completion-criteria
Feb 23, 2022
Merged

Support adding completion criteria and validating its structure#3318
rtibbles merged 9 commits intolearningequality:unstablefrom
bjester:completion-criteria

Conversation

@bjester
Copy link
Copy Markdown
Member

@bjester bjester commented Jan 27, 2022

Summary

Description of the change(s) you made

  • Adds handling for saving completion criteria to node's options
  • Updates frontend isNodeComplete logic to validate completion criteria
  • Adds new JS dependencies for ajv and kolibri-constants

Reviewer guidance

How can a reviewer test these changes?

  • Remaining frontend implementation remains a TODO

Are there any risky areas that deserve extra testing?

References

Requires learningequality/le-utils#102

Comments

Frontend isNodeComplete does not validate that certain completion criteria models are only applicable to certain content kinds (model: "pages" <> kind: "audio") Done!


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@bjester bjester marked this pull request as ready for review February 2, 2022 22:11
@bjester bjester linked an issue Feb 2, 2022 that may be closed by this pull request
@bjester bjester requested review from rtibbles and sairina February 2, 2022 22:16
@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
4.9% 4.9% Duplication

@bjester bjester added this to the 2022Q1 Phase 1: tasks milestone Feb 15, 2022
@rtibbles
Copy link
Copy Markdown
Member

I think the only thing left to do here might be to rebase after your duration PR was merged and recreate the migrations accordingly?

@bjester bjester force-pushed the completion-criteria branch from c950872 to 8431cec Compare February 23, 2022 18:45
Copy link
Copy Markdown
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot, good to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support completion criteria for content nodes

2 participants