Skip to content

Extract media duration on upload#3317

Merged
rtibbles merged 3 commits intolearningequality:unstablefrom
bjester:media-duration
Feb 21, 2022
Merged

Extract media duration on upload#3317
rtibbles merged 3 commits intolearningequality:unstablefrom
bjester:media-duration

Conversation

@bjester
Copy link
Copy Markdown
Member

@bjester bjester commented Jan 27, 2022

Summary

Description of the change(s) you made

  • Extracts the media duration when uploading audio or video files
  • Maps the maximum duration to the related content node on publish

Manual verification steps performed

  1. Upload a video
  2. Verify duration is saved in DB
  3. Publish channel
  4. Verify duration exists in channel database export

References

Resolves #3078

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.0% 5.0% Duplication

@bjester bjester added this to the 2022Q1 Phase 1: tasks milestone Feb 15, 2022
Copy link
Copy Markdown
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code read through looks good, will take it for a manual test to be sure!

Copy link
Copy Markdown
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upload and publish both set duration in the appropriate places.

Saw a validation error for FileUpload preset props, but seems to be unrelated to changes here.

@rtibbles rtibbles merged commit 6208e94 into learningequality:unstable Feb 21, 2022
@pcenov
Copy link
Copy Markdown
Member

pcenov commented Sep 20, 2022

Hi @bjester

  1. In all of the uploaded resources I see the original resource time plus an additional 1 second. For example if I upload a 5 seconds long .mp4 file I see the 'Duration>Exact time to complete value' set to 00:00:06. Is there a specific reason for that and would you consider it problematic?
  2. If I change the value of the Duration drop-down to 'Reference' then I'm no longer able to set it back to 'Exact time to complete' or any of the other options. I've created a follow up issue for that here: Hotfixes - Cannot deselect the 'Reference' option in the 'Duration' drop-down #3659

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatically set 'duration' property for videos and audio on upload

3 participants