fix: wrong status code on insufficient storage#3312
Merged
bjester merged 3 commits intolearningequality:unstablefrom Jan 28, 2022
Merged
fix: wrong status code on insufficient storage#3312bjester merged 3 commits intolearningequality:unstablefrom
bjester merged 3 commits intolearningequality:unstablefrom
Conversation
rtibbles
reviewed
Jan 13, 2022
bjester
requested changes
Jan 13, 2022
Member
bjester
left a comment
There was a problem hiding this comment.
Grepping the frontend code for 418 brings up a few places that should be updated
Member
Author
|
@bjester updated. |
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Sep 15, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Summary
This PR fixes the wrong status code 418 being responded to insufficient storage on user's disk.
Reviewer guidance
Is 400 the expected status code or we should return something else?
References
Refers #3285
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)