fix: don't publish tags greater than 30 chars#3310
fix: don't publish tags greater than 30 chars#3310bjester merged 5 commits intolearningequality:unstablefrom
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
bjester
left a comment
There was a problem hiding this comment.
I left a note regarding the changes to the ricecooker API. Could you also add some validation to the frontend API? It should be straightforward to add some validation logic to the serializer or serializer field TagField.
The other last remaining piece is what to do with channels that currently have this issue, but that can be completed in a separate PR
|
@vkWeb Good thinking on updating the max length on the The test failure is due to a migrations check which ensures that all necessary model changes are reflected in the migration files, and that model field change requires a new Django migration. The problem, though, is that if we deploy that migration to the production database which already had tags of >= 30 chars, it will likely fail. |








Summary
Description of the change(s) you made
Tags greater than 30 characters won't get published after we merge this PR.
References
Closes #3296.
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)