Skip to content

chore: minio 3.0.3 -> 7.1.1#3300

Merged
bjester merged 3 commits intolearningequality:unstablefrom
vkWeb:upgrade-minio
Nov 22, 2021
Merged

chore: minio 3.0.3 -> 7.1.1#3300
bjester merged 3 commits intolearningequality:unstablefrom
vkWeb:upgrade-minio

Conversation

@vkWeb
Copy link
Copy Markdown
Member

@vkWeb vkWeb commented Nov 18, 2021

Summary

Description of the change(s) you made

⚠️ First, test this PR with python 3.6 enviornment and then only merge it.⚠️

minio was pinned to 3.0.3 which is incompatible with python versions above 3.6. This PR upgrades the minio dependency to its latest major. There has been a lot of breaking changes since then, so, suitable changes has been made to make Kolibri studio work with minio 7.1.1.

Manual verification steps performed

I tested setting up Kolibri studio on python 3.9 and its working absolutely fine.


Reviewer guidance

How can a reviewer test these changes?

To test these changes the reviewer should setup Kolibri studio on python 3.6 and then on version python 3.9. Kolibri studio should work on both the python versions without any dependency conflicts.

Are there any risky areas that deserve extra testing?

Yes, we must test this PR with python 3.6 enviornment as I can't install python 3.6 on my machine due to Ubuntu 21.10 reasons.

References

Closes #1819.


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles requested review from bjester and rtibbles November 18, 2021 00:23
Copy link
Copy Markdown
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review looks good. There are some test failures during teardown trying to delete the bucket. Also, it would be good cleanup to delete the start_minio and stop_minio functions as they're no longer used.

@vkWeb
Copy link
Copy Markdown
Member Author

vkWeb commented Nov 20, 2021

@bjester now, the tests should pass and I've removed the unused functions.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vkWeb vkWeb requested a review from bjester November 20, 2021 18:08
Copy link
Copy Markdown
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bjester bjester merged commit 7594dc2 into learningequality:unstable Nov 22, 2021
@vkWeb vkWeb deleted the upgrade-minio branch November 22, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace minio with boto3

2 participants