chore: minio 3.0.3 -> 7.1.1#3300
Merged
bjester merged 3 commits intolearningequality:unstablefrom Nov 22, 2021
Merged
Conversation
bjester
reviewed
Nov 19, 2021
Member
bjester
left a comment
There was a problem hiding this comment.
Initial review looks good. There are some test failures during teardown trying to delete the bucket. Also, it would be good cleanup to delete the start_minio and stop_minio functions as they're no longer used.
Member
Author
|
@bjester now, the tests should pass and I've removed the unused functions. |
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Sep 15, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Summary
Description of the change(s) you made
miniowas pinned to3.0.3which is incompatible with python versions above 3.6. This PR upgrades theminiodependency to its latest major. There has been a lot of breaking changes since then, so, suitable changes has been made to make Kolibri studio work withminio 7.1.1.Manual verification steps performed
I tested setting up Kolibri studio on python 3.9 and its working absolutely fine.
Reviewer guidance
How can a reviewer test these changes?
To test these changes the reviewer should setup Kolibri studio on python 3.6 and then on version python 3.9. Kolibri studio should work on both the python versions without any dependency conflicts.
Are there any risky areas that deserve extra testing?
Yes, we must test this PR with python 3.6 enviornment as I can't install python 3.6 on my machine due to Ubuntu 21.10 reasons.
References
Closes #1819.
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)