Fixes two Django 1.11 to 3.2 upgrade issues in search.#3172
Merged
bjester merged 1 commit intolearningequality:hotfixesfrom May 26, 2021
Merged
Fixes two Django 1.11 to 3.2 upgrade issues in search.#3172bjester merged 1 commit intolearningequality:hotfixesfrom
bjester merged 1 commit intolearningequality:hotfixesfrom
Conversation
Fixes two Django 1.11 to 3.2 upgrade issues in search.
bjester
approved these changes
May 26, 2021
Member
bjester
left a comment
There was a problem hiding this comment.
Quick scan of the code looks good
Member
|
@rtibbles I'm not getting the 500 error anymore but cannot say that the search is working now as I'm constantly getting 524 timeout errors regardless of the entered search term. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Description of the change(s) you made
user.is_anonymousas a method not a propertydjango_filterinitialization arguments fromnametofield_nameManual verification steps performed
Screenshots (if applicable)
Does this introduce any tech-debt items?
Reviewer guidance
How can a reviewer test these changes?
Are there any risky areas that deserve extra testing?
References
Fixes #3168
Comments
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)