Skip to content

Sprint release 2021-05-10 strings#3154

Merged
bjester merged 1 commit intolearningequality:hotfixesfrom
bjester:sprint-release-2021-05-10-strings
May 18, 2021
Merged

Sprint release 2021-05-10 strings#3154
bjester merged 1 commit intolearningequality:hotfixesfrom
bjester:sprint-release-2021-05-10-strings

Conversation

@bjester
Copy link
Copy Markdown
Member

@bjester bjester commented May 18, 2021

Summary

Copies existing translations for new added string in https://github.com/learningequality/studio/pull/3152/files

"AdministrationAppError.unauthorizedDetails": "يجب أن تكون مسؤولاً في الاستوديو لتتمكن من عرض هذه الصفحة",
"AdministrationIndex.channelsLabel": "القنوات",
"AdministrationIndex.usersLabel": "المستخدمون"
"AdministrationIndex.usersLabel": "المستخدمون",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjester How come was this missing only in Arabic?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff is only due to the trailing comma. I tried to place the new strings into the JSON files somewhat alphabetically, but this one appeared all out of order so I just put it at the bottom

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, just checking 👍🏽

Copy link
Copy Markdown
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 💯

"AdministrationAppError.unauthorizedDetails": "يجب أن تكون مسؤولاً في الاستوديو لتتمكن من عرض هذه الصفحة",
"AdministrationIndex.channelsLabel": "القنوات",
"AdministrationIndex.usersLabel": "المستخدمون"
"AdministrationIndex.usersLabel": "المستخدمون",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, just checking 👍🏽

@bjester bjester merged commit 73d11c7 into learningequality:hotfixes May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants