Skip to content

Check if user is anonymous before checking if admin.#3151

Merged
bjester merged 1 commit intolearningequality:hotfixesfrom
rtibbles:is_admin_is_anon
May 17, 2021
Merged

Check if user is anonymous before checking if admin.#3151
bjester merged 1 commit intolearningequality:hotfixesfrom
rtibbles:is_admin_is_anon

Conversation

@rtibbles
Copy link
Copy Markdown
Member

Summary

Description of the change(s) you made

We were not checking if a user is anonymous before checking if they were an admin. This fixes that.

Manual verification steps performed

  1. Go to catalog without being logged in
  2. Look at a channel detail

References

Fixes #3144

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles requested a review from bjester May 17, 2021 14:18
@bjester bjester merged commit 0c35528 into learningequality:hotfixes May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants