Skip to content

Check event has a target before checking the target tagName.#3053

Merged
jonboiser merged 1 commit intolearningequality:hotfixesfrom
rtibbles:tagname
Mar 30, 2021
Merged

Check event has a target before checking the target tagName.#3053
jonboiser merged 1 commit intolearningequality:hotfixesfrom
rtibbles:tagname

Conversation

@rtibbles
Copy link
Copy Markdown
Member

@rtibbles rtibbles commented Mar 29, 2021

Summary

Description of the change(s) you made

  • Adds a defensive check when tagName is referenced in an event handler

Manual verification steps performed

  1. Ensure that clicking on content tiles still works

References

Fixes #2844

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2021

Codecov Report

Merging #3053 (8d8d2c2) into hotfixes (c04ed76) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           hotfixes    #3053   +/-   ##
=========================================
  Coverage     85.93%   85.93%           
=========================================
  Files           304      304           
  Lines         16403    16403           
=========================================
  Hits          14096    14096           
  Misses         2307     2307           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c04ed76...8d8d2c2. Read the comment docs.

@pcenov
Copy link
Copy Markdown
Member

pcenov commented Apr 13, 2021

Tested and verified at https://hotfixes.studio.learningequality.org/ that clicking on content tiles works correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'tagName' of undefined

4 participants