Check event has a target before checking the target tagName.#3053
Merged
jonboiser merged 1 commit intolearningequality:hotfixesfrom Mar 30, 2021
Merged
Check event has a target before checking the target tagName.#3053jonboiser merged 1 commit intolearningequality:hotfixesfrom
jonboiser merged 1 commit intolearningequality:hotfixesfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## hotfixes #3053 +/- ##
=========================================
Coverage 85.93% 85.93%
=========================================
Files 304 304
Lines 16403 16403
=========================================
Hits 14096 14096
Misses 2307 2307 Continue to review full report at Codecov.
|
jonboiser
approved these changes
Mar 30, 2021
Member
|
Tested and verified at https://hotfixes.studio.learningequality.org/ that clicking on content tiles works correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Manual verification steps performed
References
Fixes #2844
Comments
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)