Replace PrimaryDialog with KModal (and remove it along with DialogBox)#2984
Merged
rtibbles merged 6 commits intolearningequality:developfrom Feb 24, 2021
Merged
Conversation
- Removes PrimaryDialog from ChannelItem.vue as the modal handling the deletion pop-up. - Wraps the <VCard> with a <div> so that KModal can live outside of the hierarchy of the <VCard>, which wraps internals in an <a> tag resulting in clicking the action buttons in KModal following that <a> tag.
Also required moving ChannelTokenModal usage in ChannelItem such that it is rendered outside of the active wrapping DOM element so that clicking the Close button on KModal doesn't click behind it too
2 tasks
MisRob
approved these changes
Feb 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PrimaryDialogwithKModalPrimaryDialogandDialogBoxfrom the codebase (the latter was not used to begin with)Issue Addressed (if applicable)
Fixes learningequality/kolibri-design-system#158
Steps to Test
Implementation Notes (optional)
At a high level, how did you implement this?
KModaldoesn't take a v-model, so we change those to v-ifs.Then instead of using the actions slot (that both KModal and VDialog have) - we use the simpler props on KModal to apply the text for the cancel/submit buttons and the actions to take when they're clicked.
Does this introduce any tech-debt items?
Quite the opposite :)