Skip to content

Fix mismatch between Progress Modal content and current task#2982

Merged
rtibbles merged 1 commit intolearningequality:hotfixesfrom
marcellamaki:fix-progress-modal-titles
Feb 22, 2021
Merged

Fix mismatch between Progress Modal content and current task#2982
rtibbles merged 1 commit intolearningequality:hotfixesfrom
marcellamaki:fix-progress-modal-titles

Conversation

@marcellamaki
Copy link
Copy Markdown
Member

Description

This PR fixes a mismatch that was occurring where the Publish Task text was the default, and it was appearing before the Sync Task text appeared during sync tasks. It also removes some extra code and comments out (but doesn't delete) strings that aren't being used.

Issue Addressed (if applicable)

Addresses #2977

Before/After Screenshots (if applicable)

Before (Sync Task @ 0%)
sync-before

After (Sync Task @ 0%)
sync-after

Steps to Test

  • In the tree view, navigate to Sync Resources
  • Proceed through the modals - when the Progress Modal appears, there should not be a "flash" of the publish text while the task is not started/at 0%

Copy link
Copy Markdown
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and fix is manually confirmed.

@rtibbles rtibbles merged commit bd36fc2 into learningequality:hotfixes Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Onclick Sync Resources the Publish channel modal is initially displayed, Sync modal appears in a few seconds

2 participants