Skip to content

Disable usage of spreadsheet row filling#2974

Merged
rtibbles merged 1 commit intolearningequality:hotfixesfrom
rtibbles:no_sheet
Feb 20, 2021
Merged

Disable usage of spreadsheet row filling#2974
rtibbles merged 1 commit intolearningequality:hotfixesfrom
rtibbles:no_sheet

Conversation

@rtibbles
Copy link
Copy Markdown
Member

Description

Removes feedback form entirely and links to the forum.
Comments out submission to google sheet for storage request to let them go through to email

Issue Addressed (if applicable)

Fixes #2959
Fixes #2561

Before/After Screenshots (if applicable)

Before:
Screenshot from 2021-02-19 14-38-40

After:
Screenshot from 2021-02-19 15-32-30

Steps to Test

  • Make sure 'Give Feedback' in the drawer now links out to the Studio page of the community forums
  • Submitting a storage request should now not return a 500

For feedback direct users to the forum instead.
@rtibbles
Copy link
Copy Markdown
Member Author

Traceback now when submitting the storage request form, as opposed to a 500:

JSON message is:
{"From": "Kolibri Studio <noreply@learningequality.org>", "To": "content@learningequality.org,a@a.com", "Subject": "Kolibri Studio storage request", "TextBody": "\n\n\n\n\nHello Admin,\n\nThank you for your request for additional storage.\n\nHere is a copy of your request:\n==============================================================================\n\nStorage needed: 10000GB\n\nNature of content\n    Number of resources: 10000\n    Average resource size: 10MB\n    Type of resource uploaded: Corgis\n    Author/curator/aggregator: Me\n    Sample content: asdasd\n\nLicensing and access\n    Licenses: CC BY\n    Potential public channels: \n        Custom Nav Channel (4abaf7b4f0e8533fae112e650ff282ee)\n\nContent usage\n    Intended audience: asdasd\n    Target region(s): Andorra\n    Number of imports per month: 10000000000\n\nOrganization\n    Organizational affiliation: Not affiliated\n    Organization type: Not applicable\n\nUse case\nTime constraint: 1 week\n\nasdasdasd\n\n==============================================================================\n\nWe are currently reviewing the information that you have provided, and will work to be in touch in a timely manner depending on the scope of your request. While Kolibri Studio is under active development, we need to be especially mindful of how much additional storage can be provided to ensure that we can successfully continue to build the Studio tool. Many thanks in advance for your understanding.\n\n\nThanks for using Kolibri Studio!\n\nThe Learning Equality Team\n\n\n"}
"POST /settings/request_storage HTTP/1.1" 200 0
INFO:django.server:"POST /settings/request_storage HTTP/1.1" 200 0

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 19, 2021

Codecov Report

Merging #2974 (e6ad8ef) into hotfixes (28587f8) will increase coverage by 4.94%.
The diff coverage is 92.92%.

Impacted file tree graph

@@             Coverage Diff              @@
##           hotfixes    #2974      +/-   ##
============================================
+ Coverage     80.80%   85.74%   +4.94%     
============================================
  Files           281      298      +17     
  Lines         12659    15843    +3184     
============================================
+ Hits          10229    13585    +3356     
+ Misses         2430     2258     -172     
Impacted Files Coverage Δ
contentcuration/contentcuration/decorators.py 56.60% <50.00%> (-37.60%) ⬇️
...ntentcuration/contentcuration/db/models/manager.py 91.20% <90.98%> (-8.80%) ⬇️
contentcuration/contentcuration/forms.py 82.35% <94.04%> (+33.89%) ⬆️
contentcuration/contentcuration/api.py 92.06% <100.00%> (+1.43%) ⬆️
...tentcuration/contentcuration/context_processors.py 100.00% <100.00%> (ø)
...ontentcuration/contentcuration/db/advisory_lock.py 100.00% <100.00%> (ø)
...tcuration/contentcuration/db/models/expressions.py 93.33% <100.00%> (-6.67%) ⬇️
...entcuration/contentcuration/db/models/functions.py 100.00% <100.00%> (ø)
...ation/contentcuration/tests/test_rest_framework.py 36.93% <0.00%> (-63.07%) ⬇️
contentcuration/contentcuration/utils/format.py 21.05% <0.00%> (-49.54%) ⬇️
... and 181 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa98a80...fa38708. Read the comment docs.

Copy link
Copy Markdown
Contributor

@micahscopes micahscopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working

@rtibbles rtibbles merged commit c7e1b5a into learningequality:hotfixes Feb 20, 2021
@rtibbles rtibbles deleted the no_sheet branch February 20, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't request quota increase Give feedback form is missing credentials

2 participants