Allow MPTT updates when uploading tree to ensure proper order.#2954
Merged
rtibbles merged 1 commit intolearningequality:hotfixesfrom Feb 16, 2021
Merged
Allow MPTT updates when uploading tree to ensure proper order.#2954rtibbles merged 1 commit intolearningequality:hotfixesfrom
rtibbles merged 1 commit intolearningequality:hotfixesfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## hotfixes #2954 +/- ##
============================================
+ Coverage 80.80% 85.58% +4.77%
============================================
Files 281 299 +18
Lines 12659 15885 +3226
============================================
+ Hits 10229 13595 +3366
+ Misses 2430 2290 -140
Continue to review full report at Codecov.
|
rtibbles
approved these changes
Feb 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Our ricecooker API for adding nodes uses
disable_mptt_updatesand defers tree processing untilfinalize_channelis called. However, after the removal ofsort_order, this causes MPTT to order the nodes incorrectly. Correct this by removing thedisable_mptt_updatescall and allowing MPTT to order the tree properly at add time.Currently this PR has only been manually tested. Ideally, we would have a unit test that confirms the order of children, but unit tests can confirm changes do not introduce regressions.
Note that we'll want to run this with a large-ish tree on hotfixes to ensure performance isn't impacted too significantly. (I can take care of this part.)
Steps to Test
Checklist
Reviewers
If you are looking to assign a reviewer, here are some options: