Skip to content

Fix mark incomplete command for topics#2915

Merged
rtibbles merged 1 commit intolearningequality:hotfixesfrom
MisRob:mark-incomplete-fix
Feb 8, 2021
Merged

Fix mark incomplete command for topics#2915
rtibbles merged 1 commit intolearningequality:hotfixesfrom
MisRob:mark-incomplete-fix

Conversation

@MisRob
Copy link
Copy Markdown
Member

@MisRob MisRob commented Feb 8, 2021

Description

Update license validation queries to skip topics. The previous version validated licenses of topics that were previous set as complete. That doesn't make sense because we don't require license on topics and was also one part of the problem occurring for some historical topics incorrectly marked as incomplete (see "Steps to Test" for details)

Steps to Test

I've discovered this issue by restoring "Be Strong: Internet safety resources" channel that contains topics with a license set but copyright holder missing even when it's required for the license, and even when we actually don't require a license for topics nor have UI to edit it.

Then I run yarn run devsetup and many topics were marked as incomplete even though they have titles which is the only validation criteria for topics (e.g. "Module 1 - "My Digital Life").

Running yarn run devsetup on this channel with this fix should mark all topics that have a title as complete and there should be no errors in the channel editor app visible for these topics.

Comments

Related conversation https://learningequality.slack.com/archives/C0LK8QS9J/p1612791884401500

@MisRob MisRob requested a review from micahscopes February 8, 2021 18:51
@MisRob MisRob requested a review from rtibbles February 8, 2021 18:51
@MisRob MisRob added this to the Post Release Stabilization milestone Feb 8, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 8, 2021

Codecov Report

Merging #2915 (47dd0b9) into hotfixes (28587f8) will increase coverage by 4.65%.
The diff coverage is 93.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           hotfixes    #2915      +/-   ##
============================================
+ Coverage     80.80%   85.46%   +4.65%     
============================================
  Files           281      298      +17     
  Lines         12659    15794    +3135     
============================================
+ Hits          10229    13498    +3269     
+ Misses         2430     2296     -134     
Impacted Files Coverage Δ
contentcuration/contentcuration/decorators.py 56.60% <50.00%> (-37.60%) ⬇️
...ntentcuration/contentcuration/db/models/manager.py 91.20% <90.98%> (-8.80%) ⬇️
contentcuration/contentcuration/forms.py 82.85% <94.31%> (+34.40%) ⬆️
contentcuration/contentcuration/api.py 92.06% <100.00%> (+1.43%) ⬆️
...tentcuration/contentcuration/context_processors.py 100.00% <100.00%> (ø)
...ontentcuration/contentcuration/db/advisory_lock.py 100.00% <100.00%> (ø)
...tcuration/contentcuration/db/models/expressions.py 93.33% <100.00%> (-6.67%) ⬇️
...entcuration/contentcuration/db/models/functions.py 100.00% <100.00%> (ø)
...ation/contentcuration/tests/test_rest_framework.py 36.93% <0.00%> (-63.07%) ⬇️
contentcuration/contentcuration/utils/format.py 21.05% <0.00%> (-49.54%) ⬇️
... and 180 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f042992...6313a98. Read the comment docs.

@rtibbles rtibbles merged commit b190d51 into learningequality:hotfixes Feb 8, 2021
@MisRob MisRob deleted the mark-incomplete-fix branch March 15, 2021 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants