Fix mark incomplete command for topics#2915
Merged
rtibbles merged 1 commit intolearningequality:hotfixesfrom Feb 8, 2021
Merged
Fix mark incomplete command for topics#2915rtibbles merged 1 commit intolearningequality:hotfixesfrom
rtibbles merged 1 commit intolearningequality:hotfixesfrom
Conversation
rtibbles
approved these changes
Feb 8, 2021
Codecov Report
@@ Coverage Diff @@
## hotfixes #2915 +/- ##
============================================
+ Coverage 80.80% 85.46% +4.65%
============================================
Files 281 298 +17
Lines 12659 15794 +3135
============================================
+ Hits 10229 13498 +3269
+ Misses 2430 2296 -134
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update license validation queries to skip topics. The previous version validated licenses of topics that were previous set as complete. That doesn't make sense because we don't require license on topics and was also one part of the problem occurring for some historical topics incorrectly marked as incomplete (see "Steps to Test" for details)
Steps to Test
I've discovered this issue by restoring "Be Strong: Internet safety resources" channel that contains topics with a license set but copyright holder missing even when it's required for the license, and even when we actually don't require a license for topics nor have UI to edit it.
Then I run
yarn run devsetupand many topics were marked as incomplete even though they have titles which is the only validation criteria for topics (e.g. "Module 1 - "My Digital Life").Running
yarn run devsetupon this channel with this fix should mark all topics that have a title as complete and there should be no errors in the channel editor app visible for these topics.Comments
Related conversation https://learningequality.slack.com/archives/C0LK8QS9J/p1612791884401500