Added checks for existing long-running tasks on publish#2803
Merged
jayoshih merged 3 commits intolearningequality:hotfixesfrom Jan 15, 2021
Merged
Added checks for existing long-running tasks on publish#2803jayoshih merged 3 commits intolearningequality:hotfixesfrom
jayoshih merged 3 commits intolearningequality:hotfixesfrom
Conversation
rtibbles
reviewed
Jan 15, 2021
| manifest_collection = cc.File.objects.filter(contentnode=ccnode, preset_id=u"slideshow_manifest") | ||
| assert len(manifest_collection) == 1 | ||
|
|
||
| def test_blocking_task_detection(self): |
Member
There was a problem hiding this comment.
Need to actually generate the user that you are using here to assign user_id, this is causing the test failures.
rtibbles
approved these changes
Jan 15, 2021
Member
rtibbles
left a comment
There was a problem hiding this comment.
Just needs the test fix. Ran them locally with setting a user that had been created using the testdata user function, and they passed fine.
Codecov Report
@@ Coverage Diff @@
## hotfixes #2803 +/- ##
============================================
+ Coverage 80.80% 84.85% +4.05%
============================================
Files 281 292 +11
Lines 12659 15338 +2679
============================================
+ Hits 10229 13015 +2786
+ Misses 2430 2323 -107
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queries task model to see if there are any blocking tasks we need to wait for