Separate out different categories of incomplete.#2800
Merged
rtibbles merged 7 commits intolearningequality:hotfixesfrom Jan 15, 2021
Merged
Separate out different categories of incomplete.#2800rtibbles merged 7 commits intolearningequality:hotfixesfrom
rtibbles merged 7 commits intolearningequality:hotfixesfrom
Conversation
Make chunk size customizable.
jayoshih
suggested changes
Jan 15, 2021
Contributor
jayoshih
left a comment
There was a problem hiding this comment.
A few optimizations that might help speed things up
| # Mark invalid licenses | ||
| licensestart = time.time() | ||
| logging.info('Marking blank licenses...') | ||
| count = ContentNode.objects.exclude(kind_id=content_kinds.TOPIC).filter(license__isnull=True).order_by().update(complete=False) |
Contributor
There was a problem hiding this comment.
Since some might have both the title and license problem, could you use filter(complete=False) here and in other queries?
Codecov Report
@@ Coverage Diff @@
## hotfixes #2800 +/- ##
============================================
+ Coverage 80.80% 84.81% +4.01%
============================================
Files 281 292 +11
Lines 12659 15298 +2639
============================================
+ Hits 10229 12975 +2746
+ Misses 2430 2323 -107
Continue to review full report at Codecov.
|
bjester
reviewed
Jan 15, 2021
Reinstate copyright holder check. Filter by complete=False.
Separate out exercises checks.
bjester
reviewed
Jan 15, 2021
bjester
approved these changes
Jan 15, 2021
Member
bjester
left a comment
There was a problem hiding this comment.
Would suggest making the join type change, just in case, but looks good!
jayoshih
approved these changes
Jan 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes updates to the mark incomplete command to separate out different checks
Adds order_bys liberally to reduce scanning