Skip to content

Adding dots between languages on sign-in page#2789

Merged
jayoshih merged 5 commits intolearningequality:developfrom
sairina:language-dots
Jan 22, 2021
Merged

Adding dots between languages on sign-in page#2789
jayoshih merged 5 commits intolearningequality:developfrom
sairina:language-dots

Conversation

@sairina
Copy link
Copy Markdown
Contributor

@sairina sairina commented Jan 14, 2021

Description

This PR adds "dots" between the languages on the sign-in page for Studio so that it matches the links for Privacy Policy, Terms of Service, and the link to LE's website.

Issue Addressed (if applicable)

Addresses #2725

Before/After Screenshots (if applicable)

Studio RTL lang Studio LTR lang
Screen Shot 2021-01-19 at 8 37 29 PM Screen Shot 2021-01-19 at 8 37 49 PM
Difference between Kolibri and Studio (addressed in Kolibri learningequality/kolibri#7748)
Currently Kolibri
Screen Shot 2021-01-14 at 3 04 55 PM Screen Shot 2021-01-14 at 3 09 47 PM

Steps to Test

  • Step 1: Open Studio
  • Step 2: Click on the different languages at the bottom to check if the dots are showing up in the correct places

Implementation Notes (optional)

At a high level, how did you implement this?

I added some CSS classes that use pseudo-elements to create the dots (similar to the way they were created in the links below in Main.vue), added a method to either add the dots before or after a link for the language depending on whether the page is RTL/LTR and the language itself in the links is an RTL or LTR language (::before is used for RTL languages, while ::after is used for LTR languages).

Does this introduce any tech-debt items?

We will need to make sure these changes are also made in Kolibri, as it is the same component (LanguageSwitcherList) in both. There is a connected issue in Kolibri learningequality/kolibri#7748 to fix.

Checklist

  • Is the code clean and well-commented?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Are views organized into pages, components, and layouts directories as described in the docs?

Reviewers

If you are looking to assign a reviewer, here are some options:

  • Jordan jayoshih (full stack)
  • Aron aronasorman (back end, devops)
  • Micah micahscopes (full stack)
  • Kevin kollivier (back end)
  • Ivan ivanistheone (Ricecooker)
  • Richard rtibbles (full stack, Kolibri)
  • Radina @radinamatic (documentation)

@sairina sairina marked this pull request as ready for review January 20, 2021 04:53
@sairina sairina requested a review from jayoshih January 20, 2021 04:53
Copy link
Copy Markdown
Contributor

@jayoshih jayoshih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!!

@jayoshih jayoshih merged commit a2f4c9a into learningequality:develop Jan 22, 2021
@pcenov
Copy link
Copy Markdown
Member

pcenov commented Apr 27, 2021

Tested and verified as fixed at https://hotfixes.studio.learningequality.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants