Adding dots between languages on sign-in page#2789
Merged
jayoshih merged 5 commits intolearningequality:developfrom Jan 22, 2021
Merged
Adding dots between languages on sign-in page#2789jayoshih merged 5 commits intolearningequality:developfrom
jayoshih merged 5 commits intolearningequality:developfrom
Conversation
Member
|
Tested and verified as fixed at https://hotfixes.studio.learningequality.org |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds "dots" between the languages on the sign-in page for Studio so that it matches the links for Privacy Policy, Terms of Service, and the link to LE's website.
Issue Addressed (if applicable)
Addresses #2725
Before/After Screenshots (if applicable)
Difference between Kolibri and Studio (addressed in Kolibri learningequality/kolibri#7748)
Steps to Test
Implementation Notes (optional)
At a high level, how did you implement this?
I added some CSS classes that use pseudo-elements to create the dots (similar to the way they were created in the links below in
Main.vue), added a method to either add the dots before or after a link for the language depending on whether the page is RTL/LTR and the language itself in the links is an RTL or LTR language (::beforeis used for RTL languages, while::afteris used for LTR languages).Does this introduce any tech-debt items?
We will need to make sure these changes are also made in Kolibri, as it is the same component (
LanguageSwitcherList) in both. There is a connected issue in Kolibri learningequality/kolibri#7748 to fix.Checklist
pages,components, andlayoutsdirectories as described in the docs?Reviewers
If you are looking to assign a reviewer, here are some options: