Skip to content

Mime types#2771

Merged
micahscopes merged 2 commits intolearningequality:developfrom
rtibbles:mime_types
Jan 14, 2021
Merged

Mime types#2771
micahscopes merged 2 commits intolearningequality:developfrom
rtibbles:mime_types

Conversation

@rtibbles
Copy link
Copy Markdown
Member

Description

Attempts to properly set mime types for GCS upload

Issue Addressed (if applicable)

Fixes #2553

@rtibbles rtibbles requested a review from aronasorman January 14, 2021 00:56
Copy link
Copy Markdown
Collaborator

@aronasorman aronasorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see epubs mentioned here!

@jayoshih jayoshih mentioned this pull request Jan 14, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 14, 2021

Codecov Report

Merging #2771 (4ca5990) into develop (0fac4b1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2771      +/-   ##
===========================================
+ Coverage    84.92%   84.94%   +0.02%     
===========================================
  Files          309      309              
  Lines        15346    15367      +21     
===========================================
+ Hits         13033    13054      +21     
  Misses        2313     2313              
Impacted Files Coverage Δ
...ation/contentcuration/tests/test_storage_common.py 100.00% <100.00%> (ø)
...ntcuration/contentcuration/utils/storage_common.py 92.30% <100.00%> (+0.41%) ⬆️
...ontentcuration/contentcuration/viewsets/channel.py 78.94% <0.00%> (+0.49%) ⬆️
contentcuration/contentcuration/viewsets/user.py 71.62% <0.00%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fac4b1...4ca5990. Read the comment docs.

@micahscopes micahscopes merged commit 8ac585f into learningequality:develop Jan 14, 2021
@rtibbles rtibbles deleted the mime_types branch January 14, 2021 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Epubs and HTML zips are failing to upload

3 participants