Skip to content

Make sure we recalculate user storage on updates#2749

Merged
jayoshih merged 2 commits intolearningequality:developfrom
jayoshih:file
Jan 13, 2021
Merged

Make sure we recalculate user storage on updates#2749
jayoshih merged 2 commits intolearningequality:developfrom
jayoshih:file

Conversation

@jayoshih
Copy link
Copy Markdown
Contributor

When I upload new files, it isn't updating the user storage because the serializer update code doesn't call the File.save() method. This just calculates on the update function

@jayoshih jayoshih requested a review from kollivier January 12, 2021 23:59
Copy link
Copy Markdown
Contributor

@kollivier kollivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 13, 2021

Codecov Report

Merging #2749 (d58e62b) into develop (68c620b) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2749      +/-   ##
===========================================
+ Coverage    84.94%   84.98%   +0.04%     
===========================================
  Files          301      305       +4     
  Lines        15227    15265      +38     
===========================================
+ Hits         12934    12973      +39     
+ Misses        2293     2292       -1     
Impacted Files Coverage Δ
contentcuration/contentcuration/viewsets/file.py 72.22% <100.00%> (+2.52%) ⬆️
contentcuration/contentcuration/models.py 85.49% <0.00%> (-0.24%) ⬇️
contentcuration/contentcuration/tests/testdata.py 93.75% <0.00%> (-0.05%) ⬇️
contentcuration/contentcuration/utils/db_tools.py 69.75% <0.00%> (ø)
contentcuration/contentcuration/views/internal.py 85.18% <0.00%> (ø)
...ntentcuration/contentcuration/db/models/manager.py 93.49% <0.00%> (ø)
...entcuration/migrations/0128_merge_20210112_1828.py 100.00% <0.00%> (ø)
...t_assessment_item_keypair_constraint_migration_.py 100.00% <0.00%> (ø)
.../migrations/0114_assessment_item_unique_keypair.py 100.00% <0.00%> (ø)
...tentcuration/migrations/0127_auto_20210107_1707.py 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58ccce4...d58e62b. Read the comment docs.

@jayoshih jayoshih merged commit 1d6d66a into learningequality:develop Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants