Add original_channel_name annotation in ContentNode search viewset#2680
Merged
jredrejo merged 1 commit intolearningequality:developfrom Dec 12, 2020
Merged
Conversation
rtibbles
approved these changes
Dec 11, 2020
Member
|
Removing it and adding it back has the significant advantage of including @bjester's update that made sure this always returned the correct result with |
Codecov Report
@@ Coverage Diff @@
## develop #2680 +/- ##
===========================================
- Coverage 85.14% 85.14% -0.01%
===========================================
Files 299 299
Lines 15077 15079 +2
===========================================
+ Hits 12838 12839 +1
- Misses 2239 2240 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An annotated field,
original_channel_name, had been incorrectly removed for the ContentNode search as it seemed useless, but it happened to be used sometimesIssue Addressed (if applicable)
Closes: #2672
Steps to Test
When editing a channel, if a content node being the root of the channel is hit by the search , there should not be error retrieving the channel name instead of the node title.
Implementation Notes (optional)
As the annotation is added after paginating, perfomance impact should be minimal.