remove autofilled title value from contentNode

[marcellamaki]

Addresses #2565

Before/After Screenshots (if applicable)

Before:

After:

Steps to Test

• Open a channel and create a subtopic using the options menu in the side panel.
• Form should open without a title autofilled and if required field are completed, should save without error.

[MisRob]

I saw the related discussion and it makes sense to remove automatically filled title. Though it doesn't seem to be the primary cause of issues described in #2565.

The following seems to be happening:

1. createContentNode action is called with an auto filled title value in its payload
2. This payload gets merged after the default content node data here but complete field stays set to default false value even though there might be data in the payload that make the new node valid.

Although this PR helps, I assume that it's because when the topic title is left empty, complete should indeed be false because that's not a valid state for a topic, so it's not a problem that default false value for complete is used. When someone updates the topic later, updateContentNode is called and in it, complete field is updated.

I'd suggest fixing this issue in createContentNode so that we can be sure that validation is up to date whenever we call this action. Doing something like:

const contentNodeData = {
    title: '',
    description: '',
    kind,
    tags: {},
    extra_fields: {},
    [NEW_OBJECT]: true,
    changed: true,
    language: session.preferences ? session.preferences.language : session.currentLanguage,
    parent,
    ...contentDefaults,
    role_visibility: contentDefaults.role_visibility || RolesNames.LEARNER,
    ...payload,
  };

 contentNodeData.complete = isNodeComplete({ nodeDetails: contentNodeData, assessmentItems: [], files: [] })

should help.

[micahscopes]

Approved!

I didn't read the requested changes closely enough

[micahscopes]

@marcellamaki and I took a look at this today and found some funny stuff going on that might point to other underlying issues. Since it's not super high stakes, we decided it'd be best to leave this as is until @MisRob gets a chance to take a look.

[marcellamaki]

Since the UX part of the issue that the PR addresses is no longer reproducible on develop, I don't think these changes need to be merged prior to Studio relaunch. I am going to pause on this PR and put back as a draft/WIP, and reconnect with @MisRob to review her suggestions/comments about potential underlying improvements that could be made and decide how to proceed after that.

[codecov]

Codecov Report

Merging #2675 (b86ce9d) into develop (a81e7d4) will decrease coverage by 0.20%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2675      +/-   ##
===========================================
- Coverage    85.14%   84.94%   -0.21%     
===========================================
  Files          299      309      +10     
  Lines        15077    15367     +290     
===========================================
+ Hits         12838    13054     +216     
- Misses        2239     2313      +74     

Impacted Files	Coverage Δ
contentcuration/contentcuration/views/nodes.py	68.75% <0.00%> (-19.96%)	⬇️
contentcuration/contentcuration/tasks.py	62.58% <0.00%> (-12.18%)	⬇️
contentcuration/contentcuration/views/base.py	58.51% <0.00%> (-4.30%)	⬇️
contentcuration/contentcuration/api.py	92.06% <0.00%> (-2.51%)	⬇️
...ntentcuration/contentcuration/utils/gcs_storage.py	73.46% <0.00%> (-1.80%)	⬇️
.../contentcuration/tests/viewsets/test_invitation.py	89.47% <0.00%> (-1.49%)	⬇️
contentcuration/contentcuration/models.py	85.52% <0.00%> (-0.25%)	⬇️
...uration/contentcuration/tests/test_contentnodes.py	94.60% <0.00%> (-0.20%)	⬇️
contentcuration/search/viewsets/contentnode.py	52.99% <0.00%> (-0.06%)	⬇️
contentcuration/contentcuration/tests/testdata.py	93.75% <0.00%> (-0.05%)	⬇️
... and 35 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6b0135...b86ce9d. Read the comment docs.