feat: Adding Space Module Docs Improvement#1153
Open
NicolaBernini wants to merge 2 commits into
Open
Conversation
Contributor
|
Thank you for this PR, which will now be reviewed. Please If you want to bring attention to this PR, please write a message on this |
jstoobysmith
reviewed
Jun 9, 2026
| facts: the type was defined as a structure instead of an abbreviation for | ||
| `EuclideanSpace ℝ (Fin d)`. In particular, the additive and module structures | ||
| choose an origin, while the norm, inner product, and Borel structure choose the | ||
| standard Euclidean coordinate geometry on `Fin d`. |
Member
There was a problem hiding this comment.
Not sure Fin d is right here. Also this should be moved further up (either to before the first instance or placed in the module doc-string of Space.Basic.
204cd26 to
4e641c1
Compare
| @@ -21,6 +21,24 @@ The scope of this module is to define on `Space d` the structure of a `Module` | |||
| These instances require certain non-canonical choices to be made, for example the choice | |||
| of a zero and for a basis, a choice of orientation. | |||
|
|
|||
Member
There was a problem hiding this comment.
Suggested change
| ## Instances in Lean | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adding Space Module Docs Improvement