using gtk_widget_destroy instead of gtk_window_close for destory#339
Closed
sgehrman wants to merge 4 commits intoleanflutter:mainfrom
Closed
using gtk_widget_destroy instead of gtk_window_close for destory#339sgehrman wants to merge 4 commits intoleanflutter:mainfrom
sgehrman wants to merge 4 commits intoleanflutter:mainfrom
Conversation
Member
|
This PR will address the issues confirmed before closure #343 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using: gtk_widget_destroy(GTK_WIDGET(get_window(self)));
instead of:
self->_is_prevent_close = false;
gtk_window_close(get_window(self));
problem happens if you don't set prevent close, but in your own app you set:
g_signal_connect(window, "delete-event",
G_CALLBACK(gtk_widget_hide_on_delete), NULL);
then destroy won't work since it will call close and be prevented from quitting the app.