Conversation
morganthomas
added a commit
to lita-xyz/leanMultisig
that referenced
this pull request
Dec 9, 2025
# This is the 1st commit message: wip: issue/88 # This is the commit message leanEthereum#2: wip: issue/88 # This is the commit message leanEthereum#3: wip: issue/88 # This is the commit message leanEthereum#4: wip: issue/88 # This is the commit message leanEthereum#5: wip: issue/88 # This is the commit message leanEthereum#6: shrink test_match # This is the commit message leanEthereum#7: wip: issue/88 # This is the commit message leanEthereum#8: remove mark_vars_as_declared # This is the commit message leanEthereum#9: wip: issue/88 # This is the commit message leanEthereum#10: wip: issue/88 # This is the commit message leanEthereum#11: wip: issue/88 # This is the commit message leanEthereum#12: reverse stack trace order # This is the commit message leanEthereum#13: add failing test case from shrinking WHIR recursion # This is the commit message leanEthereum#14: wip: issue/88: bugfix: eliminate name shadowing # This is the commit message leanEthereum#15: refactor: remove declared_vars # This is the commit message leanEthereum#16: wip: issue/88
TomWambsgans
added a commit
that referenced
this pull request
May 9, 2026
…c#10) - realloc: switch copy_nonoverlapping -> copy. When a Vec grows inside the arena, the freshly-bumped destination can overlap the source within the same slab, violating copy_nonoverlapping's precondition (UB). - begin_phase: document that phases must not nest. A nested begin_phase recycles the slab and overwrites the outer phase's still-live data. Refcounting (per PR #10) papers over the issue but inner allocations would silently outlive their inner end_phase, so we make the flat-phase contract explicit instead. Co-authored-by: Barnadrot <kbarna.drot@gmail.com>
TomWambsgans
added a commit
that referenced
this pull request
May 9, 2026
) - realloc: switch copy_nonoverlapping -> copy. When a Vec grows inside the arena, the freshly-bumped destination can overlap the source within the same slab, violating copy_nonoverlapping's precondition (UB). - begin_phase: panic if a phase is already active. Phases must stay flat in a bump allocator: a nested begin would recycle the slab and overwrite the outer phase's still-live data. Rather than refcounting (per PR #10, which silently lets inner allocations outlive their inner end_phase), we make the violation loud via an atomic swap + assert. Co-authored-by: Barnadrot <kbarna.drot@gmail.com>
TomWambsgans
added a commit
that referenced
this pull request
May 9, 2026
) - realloc: switch copy_nonoverlapping -> copy. When a Vec grows inside the arena, the freshly-bumped destination can overlap the source within the same slab, violating copy_nonoverlapping's precondition (UB). - begin_phase: panic if a phase is already active. Phases must stay flat in a bump allocator: a nested begin would recycle the slab and overwrite the outer phase's still-live data. Rather than refcounting (per PR #10), we make the violation impossible via an assert. Co-authored-by: Barnadrot <kbarna.drot@gmail.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.