Gate find -fprint/-fprintf/-fls targets through redirect rules#152
Merged
Conversation
#151 made these file-writing actions ask, which closed the allow->ask hole but treated them as a blanket prompt. They write to a file just like a `> file` redirect, so surface the file argument as a redirect_target (the sort -o pattern) instead. Now allow-redirect pre-approves and deny-redirect hard-blocks the target, exactly matching `>` — and an unmatched write still defaults to ask.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #151, doing it properly.
#151 routed
find's-fprint/-fprint0/-fprintf/-flsto a blanketask. That closed the allow→ask hole, but it didn't make them behave like the> fileredirect they're equivalent to — it ignored the user's redirect rules:find . > FILE-fprint FILEafter #151-fprint FILEheredeny-redirect /etc/**allow-redirect /tmp/**Change
These actions write find's output to the file that follows them, so surface that file as a
redirect_targetsentry — the same patternsort -o FILEalready uses. The analyzer then matches it againstmatch_redirect, sodeny-redirecthard-blocks,allow-redirectpre-approves, and an unmatched write defaults toask. The result is identical to the equivalent> fileredirect.-delete,-exec, and-okhandling is unchanged.Tests
Added
TestFindFileWriteRedirectRules: default→ask,deny-redirect→deny,allow-redirect→approve,-fls/-fprintfgated too, and a check that-fprint FILEresolves identically to> FILE. The existing default-config cases (ask) still hold. Full suite: 11006 passing.