Merged
Conversation
Member
|
Do we need an upgrade path for existing tables, or will existing tables continue to work as expected? |
Contributor
Author
|
@danielbachhuber It continues to work in my testing so far using I could steal the migration path from #124 and bring it in here, leaving out the removal of the |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DB_CHARSETisutf8WordPress actually forces it to beutf8mb4instead.$wpdb->get_charset_collate()helper method used by SQL statements in core.Note
The schema for the
tagandaddressin thetagstable also had to be updated tovarchar(191)to supportutf8mb4which can have up to 4 bytes per character ( 191 x 4 = 767 ) and therefore would result in an error upon table creation when using InnoDB since they are both primary keys:cf.
https://developer.wordpress.org/reference/classes/wpdb/determine_charset/
https://developer.wordpress.org/reference/classes/wpdb/get_charset_collate/