Creates a layered configuration for lbrycrd start.sh#70
Merged
Leopere merged 1 commit intolbryio:masterfrom May 3, 2019
Merged
Creates a layered configuration for lbrycrd start.sh#70Leopere merged 1 commit intolbryio:masterfrom
Leopere merged 1 commit intolbryio:masterfrom
Conversation
464e6d1 to
a9ef4d0
Compare
a9ef4d0 to
d5a7583
Compare
Collaborator
|
Looks great, I have to run over this again in the morning for documentation and testing but it looks good so far! |
EnigmaCurry
added a commit
to EnigmaCurry/lbry-docker
that referenced
this pull request
May 1, 2019
* Production: Multi-stage Dockerfile. * Production: Adds VERSION ARG to specify the lbrynet version to use. * Compiler: Adds REPO ARG to specify alternate git repository to build from. * Fixes checkmount arg passing. * Adds correct binding IP address to start.sh * Adds mountable config to start.sh * Does not yet add any Layered Config like lbryio#70 (it's harder 'cause yaml)
EnigmaCurry
added a commit
to EnigmaCurry/lbry-docker
that referenced
this pull request
May 1, 2019
* Production: Multi-stage Dockerfile. * Production: Adds VERSION ARG to specify the lbrynet version to download. * Compiler: Adds REPO ARG to specify alternate git repository to build from. * Fixes checkmount arg passing. * Adds correct binding IP address to start.sh * Adds mountable config to start.sh * Does not yet add any Layered Config like lbryio#70 (it's harder 'cause yaml)
Merged
EnigmaCurry
added a commit
to EnigmaCurry/lbry-docker
that referenced
this pull request
May 1, 2019
* Production: Multi-stage Dockerfile. * Production: Adds VERSION ARG to specify the lbrynet version to download. * Compiler: Adds REPO ARG to specify alternate git repository to build from. * Fixes checkmount arg passing. * Adds correct binding IP address to start.sh * Adds mountable config to start.sh * Does not yet add any Layered Config like lbryio#70 (it's harder 'cause yaml)
EnigmaCurry
added a commit
to EnigmaCurry/lbry-docker
that referenced
this pull request
May 1, 2019
* Production: Multi-stage Dockerfile. * Production: Adds VERSION ARG to specify the lbrynet version to download. * Compiler: Adds REPO ARG to specify alternate git repository to build from. * Fixes checkmount arg passing. * Adds correct binding IP address to start.sh * Adds mountable config to start.sh * Does not yet add any Layered Config like lbryio#70 (it's harder 'cause yaml)
EnigmaCurry
added a commit
to EnigmaCurry/lbry-docker
that referenced
this pull request
May 1, 2019
* Production: Multi-stage Dockerfile. * Production: Adds VERSION ARG to specify the lbrynet version to download. * Compiler: Adds REPO ARG to specify alternate git repository to build from. * Fixes checkmount arg passing. * Adds correct binding IP address to start.sh * Adds mountable config to start.sh * Does not yet add any Layered Config like lbryio#70 (it's harder 'cause yaml)
EnigmaCurry
added a commit
to EnigmaCurry/lbry-docker
that referenced
this pull request
May 3, 2019
* Production: Multi-stage Dockerfile. * Production: Adds VERSION ARG to specify the lbrynet version to download. * Compiler: Adds REPO ARG to specify alternate git repository to build from. * Fixes checkmount arg passing. * Adds correct binding IP address to start.sh * Adds mountable config to start.sh * Does not yet add any Layered Config like lbryio#70 (it's harder 'cause yaml)
Leopere
pushed a commit
that referenced
this pull request
May 4, 2019
* Production: Multi-stage Dockerfile. * Production: Adds VERSION ARG to specify the lbrynet version to download. * Compiler: Adds REPO ARG to specify alternate git repository to build from. * Fixes checkmount arg passing. * Adds correct binding IP address to start.sh * Adds mountable config to start.sh * Does not yet add any Layered Config like #70 (it's harder 'cause yaml)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already fixed it so you could specify the config file or have one generated, but we left the case open where the user could specify both environment vars and a config file.
The environment variables always supercede the values in the configuration file.
There are a few example run commands in the README.