Skip to content

YNU-63: enable Worldchain on Prod & XRPL EVM Testnet on Sandbox#424

Merged
philanton merged 1 commit intomainfrom
feat/switch-to-spectrum
Nov 11, 2025
Merged

YNU-63: enable Worldchain on Prod & XRPL EVM Testnet on Sandbox#424
philanton merged 1 commit intomainfrom
feat/switch-to-spectrum

Conversation

@philanton
Copy link
Contributor

@philanton philanton commented Nov 10, 2025

Summary by CodeRabbit

  • Chores
    • Updated blockchain network configurations to enable additional networks and optimize block processing parameters.
    • Refreshed smart contract integration details for enhanced service operations.

@philanton philanton requested a review from a team as a code owner November 10, 2025 16:21
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 10, 2025

Walkthrough

Configuration updates to blockchain entries in production and sandbox environments. World chain is enabled by removing disabled flag and block step parameter. Linea balance checker address is updated in production. XRPL EVM block step parameters are removed in production while XRPL EVM testnet is enabled in sandbox.

Changes

Cohort / File(s) Change Summary
Production blockchain config
clearnode/chart/config/prod/blockchains.yaml
Enabled world_chain by removing disabled flag; removed block_step (499) from world_chain; removed block_step from xrpl_evm; updated linea balance_checker address from 0x424A079B89571a515Fd6fe0ba614060D5Fd8E16A to 0xF62e6a41561b3650a69Bb03199C735e3E3328c0D
Sandbox blockchain config
clearnode/chart/config/sandbox/blockchains.yaml
Added block_step: 5000 to linea_sepolia; enabled xrpl_evm_testnet by removing disabled flag; removed block_step (499) from xrpl_evm_testnet

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify the updated Linea balance_checker address is correct and authorized
  • Confirm block_step value (5000) for linea_sepolia is appropriate for testnet performance
  • Ensure enabling world_chain and xrpl_evm_testnet won't create service disruptions or unmet dependencies

Possibly related PRs

Suggested reviewers

  • alessio

Poem

🐰 A world chain awakens from slumber deep,
While stepping stones are removed from the keep,
Linea's balance checker gets a fresh address,
XRPL testnet joins—no more distress! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically summarizes the main changes: enabling Worldchain on production and XRPL EVM testnet on sandbox, which aligns with the file modifications shown in the raw summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/switch-to-spectrum

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ef21d52 and f8b7ad3.

📒 Files selected for processing (2)
  • clearnode/chart/config/prod/blockchains.yaml (1 hunks)
  • clearnode/chart/config/sandbox/blockchains.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Test (Integration) / Test Integration
  • GitHub Check: Build and Publish (Clearnode)
  • GitHub Check: Analyze (go)
🔇 Additional comments (5)
clearnode/chart/config/sandbox/blockchains.yaml (2)

22-22: Verify block_step parameter for linea_sepolia.

Block step of 5000 has been added to linea_sepolia. Ensure this value is appropriate for block syncing on Linea Sepolia testnet and consistent with other testnet configurations.


23-28: Enable xrpl_evm_testnet by removing disabled flag.

The xrpl_evm_testnet blockchain is now enabled in sandbox by removing the disabled: true flag and the block_step: 499 parameter. This aligns with the PR objective to enable XRPL EVM Testnet on sandbox.

clearnode/chart/config/prod/blockchains.yaml (3)

10-13: Enable world_chain in production.

The world_chain blockchain is now enabled in production by removing the disabled: true flag and the block_step: 499 parameter. This aligns with the PR objective to enable Worldchain on Prod.


33-33: Verify balance_checker address update for linea.

The balance_checker address for linea has been updated from 0x424A079B89571a515Fd6fe0ba614060D5Fd8E16A to 0xF62e6a41561b3650a69Bb03199C735e3E3328c0D. This is a production change that requires verification to ensure:

  • The new address is correct for the linea balance checker contract
  • Any dependent systems or integrations using the old address are updated
  • The address is already deployed and operational on mainnet

34-37: Confirm block_step removal from xrpl_evm.

The block_step parameter has been removed from the xrpl_evm blockchain configuration. Verify that this removal is intentional and does not impact block syncing or indexing behavior for XRPL EVM on mainnet.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @philanton, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating blockchain configurations across both production and sandbox environments. It enables the Worldchain on production and activates the XRPL EVM Testnet within the sandbox. Additionally, it includes an update to the balance checker address for Linea in production and refines the block step settings for several blockchain entries to ensure correct operation and integration.

Highlights

  • Worldchain Enabled on Production: The world_chain configuration has been updated to remove the disabled: true flag, effectively enabling it for production environments.
  • XRPL EVM Testnet Enabled on Sandbox: The xrpl_evm_testnet configuration in the sandbox environment has been updated to remove the disabled: true flag, making it active.
  • Linea Balance Checker Update: The balance_checker contract address for linea in the production configuration has been updated to a new address.
  • Block Step Configuration Adjustments: Several block_step configurations were removed for world_chain and xrpl_evm in production, and for xrpl_evm_testnet in sandbox. A new block_step was added for linea in sandbox.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables Worldchain on production and XRPL EVM Testnet on sandbox environments by updating their respective blockchain configuration files. While the changes correctly enable these chains, I've noticed that the block_step parameter has been removed for world_chain, xrpl_evm (in production), and xrpl_evm_testnet (in sandbox). This will cause them to use the default block_step of 10,000, a significant increase from the previous value of 499. This could have performance implications for block scanning. I've added comments with suggestions to restore the block_step if this change was unintentional. The other configuration changes appear to be in order.

@philanton philanton merged commit 2b52152 into main Nov 11, 2025
13 checks passed
@philanton philanton deleted the feat/switch-to-spectrum branch November 11, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants