feat: Support System.Diagnostics.DiagnosticSource version 10.*#254
Merged
Conversation
Contributor
Author
|
@launchdarkly/team-sdk-net, what is status? |
3078c30 to
3836100
Compare
jsonbailey
approved these changes
May 15, 2026
Contributor
|
@bstordrup Thanks for submitting the PR and issue. I've tested the builds locally and everything looks good. |
jsonbailey
pushed a commit
that referenced
this pull request
May 15, 2026
🤖 I have created a release *beep* *boop* --- ## [1.5.0](LaunchDarkly.ServerSdk.Telemetry-v1.4.0...LaunchDarkly.ServerSdk.Telemetry-v1.5.0) (2026-05-15) ### Features * Support System.Diagnostics.DiagnosticSource version 10.* ([#254](#254)) ([034538e](034538e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: this PR is a release/version bump with documentation updates and no functional code changes in the runtime library shown in the diff. > > **Overview** > Publishes `pkgs/telemetry` **v1.5.0** by updating the version in `.release-please-manifest.json` and `LaunchDarkly.ServerSdk.Telemetry.csproj`. > > Updates release metadata/docs by adding a `1.5.0` entry to `pkgs/telemetry/CHANGELOG.md` (noting DiagnosticSource 10.* support) and bumping the example `SDK_VERSION` in `pkgs/telemetry/PROVENANCE.md`. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit c778754. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
Author
|
@jsonbailey thank you. |
Contributor
|
LaunchDarkly.ServerSdk.Telemetry: v1.5.0 should now be available with the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Closes #253
Describe the solution you've provided
Raised the upper version range limit on
System.Diagnostics.DiagnosticSourceto 11 instead of 10Describe alternatives you've considered
Considered to completely remove the upper limit, but decided for the upper limit raise as done in an earlier pull request (#149) to support version 9x of the same library.
Note
Low Risk
Low risk dependency-range change limited to the telemetry package project file; main risk is unexpected compatibility issues when consumers resolve newer
DiagnosticSourceversions.Overview
Updates
LaunchDarkly.ServerSdk.Telemetry.csprojto widen theSystem.Diagnostics.DiagnosticSourcedependency upper bound from<10to<11fornetstandard2.0/net462, enabling compatibility with10.xversions (while keepingnet8.0relying on the built-in package).Reviewed by Cursor Bugbot for commit 3836100. Bugbot is set up for automated code reviews on this repo. Configure here.