Replace Hackney with Req as HTTP client#165
Open
ry4n1m3 wants to merge 1 commit into
Open
Conversation
Addresses security concerns with Hackney (CVE-2018-1000007, AIKIDO-2026-10122). Req provides a modern, actively maintained HTTP client built on Mint. Changes: - Add Req as required dependency, remove Hackney - Implement Tzdata.HTTPClient.Req with redirect support - Set Req as default HTTP client in configuration - Hackney implementation remains available for backward compatibility - Update README with migration information Co-Authored-By: Matt Wynne <matt.wynne@mechanical-orchard.com>
|
This would be great! |
|
Plus one. @lau, any chance this could get merged and released? |
metabren
added a commit
to Finger-Ink/notifiex
that referenced
this pull request
May 13, 2026
Internal HTTP/JSON client swap. Public API unchanged. Motivated by Hackney's security history; mirrors lau/tzdata#165. Also bumps Elixir floor to 1.15, modernises ex_doc/credo/dialyxir, and moves CI to OTP 26 / Elixir 1.17. Adds Bypass-backed tests for the Slack and Discord services (0% → 85%/100% on those modules). Caller-visible breaking change: transport-error reasons are now strings ("connection refused") rather than atoms (:econnrefused). Tuple shape {:error, {:error, reason}} is unchanged. See CHANGELOG.md and guides/upgrading_to_v2.md.
Tyler-pierce
approved these changes
May 20, 2026
|
With the recent CVEs and hackney 4.x.x released, can we get this one merged? |
acrogenesis
added a commit
to valiot/tzdata
that referenced
this pull request
Jun 9, 2026
…ff by default Follow-up to the Hackney→Req switch (PR lau#165): - The Req HTTP client now issues requests through the `Tzdata.Finch` pool that `Tzdata.App` already starts. As applied, the supervised pool was started but unused (Req fell back to its own default Finch), leaving a dead process; both get/3 and head/3 now pass `finch: Tzdata.Finch`. - Exclude `:integration` (live IANA) and `:req` (httpbin) tags by default in test_helper so the suite is deterministic/offline; tag the Finch pool test `:integration` since it makes a live request. Run them with `mix test --include integration --include req`. Verified on Elixir 1.20.1/OTP 29: req ~> 0.5 resolves to 0.6.1, no hackney in the tree, and the full update path (ensure_all_started(:tzdata) + ReleaseUpdater.poll_for_update) downloads the live IANA release (2026b) and builds periods with no FunctionClauseError. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses security concerns with Hackney (CVE-2018-1000007, AIKIDO-2026-10122). Req provides a modern, actively maintained HTTP client built on Mint.
Changes:
Licensing: This contribution is made by employees of Mechanical Orchard, Inc. under the terms of the project's license.