Skip to content

[codex] Respect --brand lark in config init --new#4

Open
jnuyao wants to merge 1 commit intolarksuite:mainfrom
jnuyao:codex/honor-lark-brand-init
Open

[codex] Respect --brand lark in config init --new#4
jnuyao wants to merge 1 commit intolarksuite:mainfrom
jnuyao:codex/honor-lark-brand-init

Conversation

@jnuyao
Copy link
Copy Markdown

@jnuyao jnuyao commented Mar 28, 2026

Summary

  • respect --brand lark in config init --new
  • preserve the requested Lark brand in the saved config and JSON output
  • surface the existing Lark endpoint retry message during app registration
  • add a regression test for the --new --brand lark path

Root cause

config init --new hard-coded core.BrandFeishu when entering the create-app flow, so the requested brand never reached the setup URL generation path.

Testing

  • go test ./cmd/config
  • go test ./internal/auth ./internal/core
  • go test ./...
    • this still fails in internal/registry on pre-existing tests:
      • TestColdStart_UsesEmbedded
      • TestCacheHit_WithinTTL

@jnuyao jnuyao marked this pull request as ready for review March 28, 2026 08:21
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 30, 2026

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants