fix(web): clear responding state when annotation reply ends without workflow events#37365
Closed
leslie2046 wants to merge 7 commits into
Closed
fix(web): clear responding state when annotation reply ends without workflow events#37365leslie2046 wants to merge 7 commits into
leslie2046 wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.fixes #37362
Summary
This PR fixes a UI state issue where the response may remain in the responding state after an Annotation Reply finishes.
The issue affected both:
Root Cause
In the annotation reply fast path, the SSE stream may end with
message_endwithout ever starting a workflow.Previously, the frontend mainly relied on workflow lifecycle events to clear the responding state, so the UI could keep showing "Stop responding" even though the response had already finished.
Fix
message_endas a terminal signal when the current response never entered workflow stateTests
Added targeted test coverage for:
app/components/base/chat/chat/__tests__/hooks.spec.tsxapp/components/workflow/panel/debug-and-preview/__tests__/hooks/sse-callbacks.spec.tsNot run locally.
From gpt-5.5 codex
Screenshots
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint gods