-
Notifications
You must be signed in to change notification settings - Fork 20k
fix(openai): correct image resize aspect ratio caps #34192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@ccurme waiting for your review |
CodSpeed Performance ReportMerging #34192 will not alter performanceComparing Summary
Footnotes
|
ccurme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a usage example that demonstrates that something is broken or wrong?
The resize bug is covered by |
Summary
_resizeinlangchain_openai.chat_models.baseso the smaller side is scaled with its own dimension, preserving aspect ratio (e.g., 2048x4096 -> 768x1536)Fixes #34191
Testing