Skip to content

Conversation

@wjones127
Copy link
Contributor

@wjones127 wjones127 commented Jan 15, 2026

As we add new data types, we'll want a spec we can modify in proposed PRs. This adds a spec for the schema and data types, as well as the high-level encoding strategy.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 15, 2026
@github-actions
Copy link
Contributor

PR Review: docs: add schema specification

This PR adds comprehensive documentation for the Lance schema specification. The documentation is well-structured and accurate based on code verification.

Summary

The PR introduces a new schema.md file documenting:

  • Data type mappings (logical types to Arrow types)
  • Field structure and properties
  • Field ID assignment and tombstoning semantics
  • Schema evolution operations
  • Blob column formats (v1 and v2)

Verification

I verified the following against the codebase:

  • Logical type mappings: Match implementation in rust/lance-core/src/datatypes.rs:139-231
  • Blob v2 descriptor fields: Match BLOB_V2_DESC_FIELDS in rust/lance-core/src/datatypes.rs:49-57
  • Field ID semantics: Consistent with existing documentation in index.md

No Issues Found

The documentation accurately reflects the implementation. No P0/P1 issues identified.

LGTM ✓

@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@wjones127 wjones127 marked this pull request as ready for review January 26, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant