Skip to content

Add ability to pull from repo url#233

Merged
brienw merged 10 commits into
labzero:masterfrom
StephaneRob:git_pull
Oct 9, 2018
Merged

Add ability to pull from repo url#233
brienw merged 10 commits into
labzero:masterfrom
StephaneRob:git_pull

Conversation

@StephaneRob
Copy link
Copy Markdown
Contributor

@StephaneRob StephaneRob commented Mar 2, 2018

  • require that remote servers already have the authentication set up for their git provider
  • Need to add tests

@StephaneRob StephaneRob changed the title Git pull Add ability to pull from repo url Mar 2, 2018
@StephaneRob
Copy link
Copy Markdown
Contributor Author

fix #175

@brienw
Copy link
Copy Markdown
Contributor

brienw commented Mar 2, 2018

WHOA! thank you for this! I don't know if i'll have time to look it over today, but i'll give it a peak next week (or possibly this weekend)

@brienw
Copy link
Copy Markdown
Contributor

brienw commented Mar 9, 2018

Ok, jeesh, we finally just got that big DSL refactor merged in. Would you mind updating this branch? Hopefully the merge conflicts aren't too major if there are any.

NOTE: After the refactor I just merged in use Bootleg.Config has been deprecated in favor of use Bootleg.DSL in order to pull in all the DSL macros.

@StephaneRob
Copy link
Copy Markdown
Contributor Author

I've just seen the DSL refactor, it's great !
I'm going to update this branch with last commits. I didn't have time to add tests this week but i'll work on this weekend.

Do you have any idea about the best way to integrate this test ?

@brienw
Copy link
Copy Markdown
Contributor

brienw commented Mar 12, 2018

I would look at setting up a fixture project that also contains a second checkout of the git repo somewhere locally (could even be inside the docker container). Then add the second local repo as a remote of the main project git repo. That should allow you to test that your pull method works. You could have the 'remote' repo set up to be like one commit ahead or behind so that you can verify commit hashes and assert that you see the one you would expect.

@StephaneRob
Copy link
Copy Markdown
Contributor Author

Updated the branch.
Let me know if tests I added for this feature are good enough.

@brienw
Copy link
Copy Markdown
Contributor

brienw commented Oct 9, 2018

Thank you @StephaneRob and @rjanja, this is rad!

@brienw brienw merged commit de0a42b into labzero:master Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants