Add govulncheck to CI and bump dependencies#2362
Merged
Merged
Conversation
933905e to
97db223
Compare
eafcf93 to
bc75cc2
Compare
Contributor
Author
|
@lammel please review |
lammel
approved these changes
Dec 14, 2022
lammel
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Great to see govulncheck for echo. Should help when releasing.
Let's see how many vuln warnings we get.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add https://pkg.go.dev/golang.org/x/vuln/cmd/govulncheck to CI flow and bump dependencies
I had to refactor CI flow to 2 parts as
govulncheckreports problem for older Go versions thus causing workflow to fail. Therefore run static analysis only with latest Go version. There is no point to run golint and staticcheck with older versions as they are almost always teemed to fail (because of vulns that have patched in later versions).I added
env.LATEST_GO_VERSIONso it is easier in future to change Go version for step where are using it"single" version of GO.