Skip to content

NO-JIRA | docs: include necessary dependencies#1026

Merged
tupyy merged 1 commit intokubev2v:mainfrom
celdrake:update-docs
Apr 7, 2026
Merged

NO-JIRA | docs: include necessary dependencies#1026
tupyy merged 1 commit intokubev2v:mainfrom
celdrake:update-docs

Conversation

@celdrake
Copy link
Copy Markdown
Contributor

In the process of following the run-locally doc, the following dependencies are required and they should be stated in the prerequisites section.

@celdrake celdrake requested a review from a team as a code owner March 27, 2026 09:32
@celdrake celdrake requested review from nirarg and tupyy and removed request for a team March 27, 2026 09:32
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 27, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • doc/run-locally.md is excluded by !**/*.md

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 44d75e6d-a734-4807-a6df-d69f64157442

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Collaborator

@nirarg nirarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @celdrake

@AvielSegev
Copy link
Copy Markdown
Collaborator

Hi @celdrake and thanks for the PR!

Can you please add NO-JIRA | docs: perfix to your commit message?

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AvielSegev, nirarg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AvielSegev
Copy link
Copy Markdown
Collaborator

/ok-to-test

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 7, 2026

New changes are detected. LGTM label has been removed.

Signed-off-by: Celia Amador <camadorg@redhat.com>
@celdrake
Copy link
Copy Markdown
Contributor Author

celdrake commented Apr 7, 2026

@AvielSegev Thanks, done now!

@tupyy
Copy link
Copy Markdown
Collaborator

tupyy commented Apr 7, 2026

@celdrake Hi. Could you explain why do you need gcc as a dependency? I suspect it's for duckdb, but not sure why.

@celdrake
Copy link
Copy Markdown
Contributor Author

celdrake commented Apr 7, 2026

@celdrake Hi. Could you explain why do you need gcc as a dependency? I suspect it's for duckdb, but not sure why.

Seems correct, make fails with the following error if "gcc-c++" is not installed

➜ make
mkdir -p bin
go build -buildvcs=false -ldflags "-X github.com/kubev2v/migration-planner/pkg/version.majorFromGit=0 -X github.com/kubev2v/migration-planner/pkg/version.minorFromGit=10 -X github.com/kubev2v/migration-planner/pkg/version.patchFromGit=0 -X github.com/kubev2v/migration-planner/pkg/version.versionFromGit=v0.10.0-8-g61f61a7 -X github.com/kubev2v/migration-planner/pkg/version.commitFromGit=61f61a7cf52c3eccb8eb4c671e436abfa7540c30 -X github.com/kubev2v/migration-planner/pkg/version.gitTreeState=clean -X github.com/kubev2v/migration-planner/pkg/version.buildDate=2026-04-07T08:30:19Z -X github.com/kubev2v/migration-planner/pkg/version.agentCommitFromGit=61f61a7cf52c3eccb8eb4c671e436abfa7540c30 -X github.com/kubev2v/migration-planner/pkg/version.agentVersionFromGit=v0.10.0-8-g61f61a7" -o /home/camadorg/dev/assisted/migration-planner/bin ./cmd/...
go: downloading github.com/duckdb/duckdb-go-bindings/linux-amd64 v0.1.24
# github.com/kubev2v/migration-planner/cmd/planner-api
/usr/lib/golang/pkg/tool/linux_amd64/link: running gcc failed: exit status 1
/usr/bin/gcc -m64 -Wl,--build-id=0x59529b15ed81529102f40f184457a1f92231d3a0 -o $WORK/b397/exe/a.out -Wl,--export-dynamic-symbol=_cgo_panic -Wl,--export-dynamic-symbol=_cgo_topofstack -Wl,--export-dynamic-symbol=authorizerTrampoline -Wl,--export-dynamic-symbol=callbackTrampoline -Wl,--export-dynamic-symbol=commitHookTrampoline -Wl,--export-dynamic-symbol=compareTrampoline -Wl,--export-dynamic-symbol=crosscall2 -Wl,--export-dynamic-symbol=doneTrampoline -Wl,--export-dynamic-symbol=preUpdateHookTrampoline -Wl,--export-dynamic-symbol=replacement_scan_callback -Wl,--export-dynamic-symbol=replacement_scan_delete_callback -Wl,--export-dynamic-symbol=rollbackHookTrampoline -Wl,--export-dynamic-symbol=scalar_udf_bind_callback -Wl,--export-dynamic-symbol=scalar_udf_bind_copy_callback -Wl,--export-dynamic-symbol=scalar_udf_callback -Wl,--export-dynamic-symbol=scalar_udf_delete_callback -Wl,--export-dynamic-symbol=stepTrampoline -Wl,--export-dynamic-symbol=table_udf_bind_chunk -Wl,--export-dynamic-symbol=table_udf_bind_row -Wl,--export-dynamic-symbol=table_udf_callback -Wl,--export-dynamic-symbol=table_udf_delete_callback -Wl,--export-dynamic-symbol=table_udf_init -Wl,--export-dynamic-symbol=table_udf_local_init -Wl,--export-dynamic-symbol=updateHookTrampoline -Wl,--compress-debug-sections=zlib /tmp/go-link-1557720986/go.o /tmp/go-link-1557720986/000000.o /tmp/go-link-1557720986/000001.o /tmp/go-link-1557720986/000002.o /tmp/go-link-1557720986/000003.o /tmp/go-link-1557720986/000004.o /tmp/go-link-1557720986/000005.o /tmp/go-link-1557720986/000006.o /tmp/go-link-1557720986/000007.o /tmp/go-link-1557720986/000008.o /tmp/go-link-1557720986/000009.o /tmp/go-link-1557720986/000010.o /tmp/go-link-1557720986/000011.o /tmp/go-link-1557720986/000012.o /tmp/go-link-1557720986/000013.o /tmp/go-link-1557720986/000014.o /tmp/go-link-1557720986/000015.o /tmp/go-link-1557720986/000016.o /tmp/go-link-1557720986/000017.o /tmp/go-link-1557720986/000018.o /tmp/go-link-1557720986/000019.o /tmp/go-link-1557720986/000020.o /tmp/go-link-1557720986/000021.o /tmp/go-link-1557720986/000022.o /tmp/go-link-1557720986/000023.o /tmp/go-link-1557720986/000024.o /tmp/go-link-1557720986/000025.o /tmp/go-link-1557720986/000026.o /tmp/go-link-1557720986/000027.o /tmp/go-link-1557720986/000028.o /tmp/go-link-1557720986/000029.o /tmp/go-link-1557720986/000030.o /tmp/go-link-1557720986/000031.o /tmp/go-link-1557720986/000032.o /tmp/go-link-1557720986/000033.o /tmp/go-link-1557720986/000034.o /tmp/go-link-1557720986/000035.o /tmp/go-link-1557720986/000036.o /tmp/go-link-1557720986/000037.o /tmp/go-link-1557720986/000038.o /tmp/go-link-1557720986/000039.o /tmp/go-link-1557720986/000040.o /tmp/go-link-1557720986/000041.o /tmp/go-link-1557720986/000042.o /tmp/go-link-1557720986/000043.o -O2 -g -lresolv -O2 -g -lpthread -O2 -g -O2 -g -ldl -O2 -g -O2 -g -rdynamic -lduckdb_static -lautocomplete_extension -lcore_functions_extension -licu_extension -ljson_extension -lparquet_extension -ljemalloc_extension -ltpcds_extension -ltpch_extension -lduckdb_fastpforlib -lduckdb_fmt -lduckdb_fsst -lduckdb_hyperloglog -lduckdb_mbedtls -lduckdb_miniz -lduckdb_pg_query -lduckdb_re2 -lduckdb_skiplistlib -lduckdb_utf8proc -lduckdb_yyjson -lduckdb_zstd -lstdc++ -lm -ldl -L/home/camadorg/go/pkg/mod/github.com/duckdb/duckdb-go-bindings/linux-amd64@v0.1.24/ -no-pie
/usr/bin/ld: cannot find -lstdc++: No such file or directory
collect2: error: ld returned 1 exit status

@tupyy tupyy merged commit 4c224c0 into kubev2v:main Apr 7, 2026
2 of 4 checks passed
@celdrake celdrake deleted the update-docs branch April 7, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants