Skip to content

images/kubekins*: apply default Docker daemon.json #36042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
neolit123 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

images/kubekins*: apply default Docker daemon.json #36042

neolit123 wants to merge 1 commit into from
+35 −9

Conversation

@neolit123
Copy link
Member

@neolit123 neolit123 commented Dec 7, 2025 •
edited
Loading

  • Use the overlay2 storage driver
  • Disable the containerd snapshotter.

Without this config we are hitting bugs when doing 'docker pull', 'docker save' from kubekins and then trying to 'ctr import' the resulted tar files

xref

slack
https://kubernetes.slack.com/archives/CN0K3TE2C/p1765057601502659

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: neolit123
Once this PR has been reviewed and has the lgtm label, please assign bentheelder for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/images sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 7, 2025
@neolit123
Copy link
Member Author

neolit123 commented Dec 7, 2025

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2025
@upodroid
Copy link
Member

upodroid commented Dec 7, 2025

When do we intend to enable containerd snapshotter?

@neolit123
images/kubekins*: apply default Docker daemon.json
5fad71b 
- Use the overlay2 storage driver
- Disable the containerd snapshotter.

Without this config we are hitting bugs when doing
'docker pull', 'docker save' from kubekins and then
trying to 'ctr import' the resulted tar files.
@neolit123 neolit123 force-pushed the 1.35-add-docker-config-in-kubekins branch from ff16908 to 5fad71b Compare December 7, 2025 15:09
@neolit123
Copy link
Member Author

neolit123 commented Dec 7, 2025

When do we intend to enable containerd snapshotter?

i don't know when, but it's is now buggy.
is there demand for it in CI; maybe in some containerd jobs?

/cc @dims

@k8s-ci-robot k8s-ci-robot requested a review from dims December 7, 2025 15:16
@neolit123 neolit123 mentioned this pull request Dec 7, 2025
Merged
@neolit123
Copy link
Member Author

neolit123 commented Dec 7, 2025

merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@cpanato cpanato Awaiting requested review from cpanato

@dims dims Awaiting requested review from dims

Assignees

No one assigned

Labels

area/images cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neolit123 @k8s-ci-robot @upodroid