Fix Dirty-commit in "Version"

[medyagh]

latest minikube version has a -dirty which means one file was touched during "source" during the release process

Update:
in the Lsat Release Jenkins Logs I see

++ out/minikube-linux-amd64 version
+ BUILT_VERSION='minikube version: v1.36.0
commit: f8f52f5de11fc6ad8244afac475e1d0f96841df1-dirty'
+ echo minikube version: v1.36.0 commit: f8f52f5de11fc6ad8244afac475e1d0f96841df1-dirty
minikube version: v1.36.0 commit: f8f52f5de11fc6ad8244afac475e1d0f96841df1-dirty
++ echo minikube version: v1.36.0 commit: f8f52f5de11fc6ad8244afac475e1d0f96841df1-dirty
++ grep commit:
++ awk '{print $2}'
+ COMMIT=version:
+ echo version:
+ grep -q dirty

which shows "dirty" but our code that is supposed to Catch it doesnt work

# check if 'commit: <commit-id>' line contains '-dirty' commit suffix
BUILT_VERSION=$("out/minikube-$(go env GOOS)-$(go env GOARCH)" version)
echo ${BUILT_VERSION}

COMMIT=$(echo ${BUILT_VERSION} | grep 'commit:' | awk '{print $2}')
if (echo ${COMMIT} | grep -q dirty); then
  echo "'minikube version' reports dirty commit: ${COMMIT}"
  exit 1
fi

[mayuka-c]

@medyagh I tested the latest release (v1.36.0), and the version output no longer includes the -dirty suffix. The issue appears to have been resolved in the current release pipeline. Looks like the issue is no longer valid

❯ out/minikube version
minikube version: v1.36.0
commit: 8c6446f

The issue can be closed if no issues :)

[medyagh]

@mayuka-c are you using the verison installed by brew?

$ /opt/homebrew/bin/minikube version
minikube version: v1.36.0
commit: f8f52f5de11fc6ad8244afac475e1d0f96841df1

$ /usr/local/bin/minikube version
minikube version: v1.36.0
commit: f8f52f5de11fc6ad8244afac475e1d0f96841df1-dirty