Skip to content

Conversation

@linpu01
Copy link
Contributor

@linpu01 linpu01 commented Dec 5, 2025

Image promotion for cloud-provider-gcp v34.2.0
This is an automated PR generated from kpromo

kpromo pr --fork linpu01 --project cloud-provider-gcp --tag v34.2.0

/hold
cc: @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects labels Dec 5, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @linpu01!

It looks like this is your first PR to kubernetes/k8s.io 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/k8s.io has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @linpu01. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/registry.k8s.io Code in registry.k8s.io/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Dec 5, 2025
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 5, 2025
@YifeiZhuang
Copy link
Contributor

It looks there are different ways of generating the images. That is why there are format is different.
@mattcary let us know if kpromo is still valid way of promoting the image. If not, what is the preferred way.
/lgtm
/assign @mattcary
cc. @upodroid

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2025
@upodroid
Copy link
Member

upodroid commented Dec 5, 2025

Hey, this shell script was ran to generate the images: https://github.com/kubernetes/k8s.io/blob/main/registry.k8s.io/images/k8s-staging-cloud-provider-gcp/generate.sh. The yaml format is different, but the generated result is the same.

In the future, we should delete this script and use kpromo/manual diffs to promote the image.

This diff is safe to merge:

 mahamed  Mac  tmp  1  ERROR  $  curl -Lo new.yaml https://github.com/linpu01/k8s.io/53be90e6a08f929c3858561f0c9a0f152bc227fe/registry.k8s.io/images/k8s-staging-cloud-provider-gcp/images.yaml
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 26801  100 26801    0     0  66363      0 --:--:-- --:--:-- --:--:-- 66503
 mahamed  Mac  tmp  1  $  curl -Lo old.yaml https://github.com/kubernetes/k8s.io/refs/heads/main/registry.k8s.io/images/k8s-staging-cloud-provider-gcp/images.yaml
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 27296  100 27296    0     0  94618      0 --:--:-- --:--:-- --:--:-- 94777
 mahamed  Mac  tmp  1  $  diff <(yq -P 'sort_by(.name)' -o=props new.yaml) <(yq -P 'sort_by(.name)' -o=props old.yaml)
15d14
< 0.dmap.sha256\:4795f50bd273894d46e21b5569a716374377ae06d276343a6e5eae5aa93d5de8.0 = v34.2.0

@YifeiZhuang
Copy link
Contributor

/assign saad-ali
/assign leiyiz

Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: linpu01, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2025
@linpu01
Copy link
Contributor Author

linpu01 commented Dec 5, 2025

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit f8e361f into kubernetes:main Dec 5, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/registry.k8s.io Code in registry.k8s.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants