chore: upgrade prometheus module to v0.303.1 #1652
Conversation
| node := &storage.MetricsPoint{} | ||
| pods := make(map[apitypes.NamespacedName]storage.PodMetricsPoint) | ||
| parser, err := textparse.New(b, "", false, nil) | ||
| parser, err := textparse.New(b, "text/plain", "", false, false, nil) |
There was a problem hiding this comment.
Because of changes in prometheus 3 module
prometheus/prometheus@421a3c2#diff-88b6f2039c68ed3e6c470170fb60854b4dc7ef381e14c690337e0db8d0a2aab9R138-R139
There was a problem hiding this comment.
Just a question:
echo from the comments of New function:
An error may also be returned if fallbackType had to be used
Using the fallbackType also gets an error? Do you know why?
|
/close |
|
@slashpai: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/reopen |
|
@slashpai: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Jayapriya Pai <[email protected]>
|
/triage accepted This isn't the blocker for cutting the new release(tracked by #1565). |
Since we are getting a release its good to get latest changes as we release very rarely. |
RainbowMango
left a comment
There was a problem hiding this comment.
/lgtm
Since currently only supports text/plain according to #1647 (comment).
| node := &storage.MetricsPoint{} | ||
| pods := make(map[apitypes.NamespacedName]storage.PodMetricsPoint) | ||
| parser, err := textparse.New(b, "", false, nil) | ||
| parser, err := textparse.New(b, "text/plain", "", false, false, nil) |
There was a problem hiding this comment.
Just a question:
echo from the comments of New function:
An error may also be returned if fallbackType had to be used
Using the fallbackType also gets an error? Do you know why?
|
/assign @dgrisonnet @serathius |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: serathius, slashpai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Installation kubectl apply -f https://github.com/kubernetes-sigs/metrics-server/releases/download/v0.8.0/components.yaml Changes since v0.7.2 Improvements * Wire server run options to flags kubernetes-sigs#1560 kubernetes-sigs#1656 (@benluddy, @slashpai) * Bump Golang to v1.24.4 and to Kubernetes clients to v0.33.2 kubernetes-sigs#1662, kubernetes-sigs#1665 (@dgrisonnet,@yangjunmyfm192085,@slashpai) * This will help to include the `disable-http2-serving` flag added in SecureServingOptions (kubernetes/kubernetes#122176) for metrics-server * Bump Prometheus module to v0.304.2 kubernetes-sigs#1652, kubernetes-sigs#1675 (@slashpai , @dependabot) Tooling * Add support for specifying other container engines kubernetes-sigs#1649 (@slashpai)
Fixes #1603
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #