Skip to content

Move to net8.0 - #1463

Merged
k8s-ci-robot merged 14 commits into
kubernetes-client:masterfrom
m3nax:move-examples-to-net8.0
Dec 1, 2023
Merged

Move to net8.0#1463
k8s-ci-robot merged 14 commits into
kubernetes-client:masterfrom
m3nax:move-examples-to-net8.0

Conversation

@m3nax

@m3nax m3nax commented Nov 22, 2023

Copy link
Copy Markdown
Contributor

.Net 8.0 was released, in order to start the migration to the newer version of framework i updated the .net version of examples to the latest. I also accorgitly updated actions to build the update projects.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 22, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 22, 2023
@tg123

tg123 commented Nov 24, 2023

Copy link
Copy Markdown
Member

great, why not move main lib to net8 as well?

@codecov-commenter

codecov-commenter commented Nov 24, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@e888e46). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1463   +/-   ##
=========================================
  Coverage          ?   69.34%           
=========================================
  Files             ?       89           
  Lines             ?     2652           
  Branches          ?      553           
=========================================
  Hits              ?     1839           
  Misses            ?      811           
  Partials          ?        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m3nax

m3nax commented Nov 24, 2023

Copy link
Copy Markdown
Contributor Author

great, why not move main lib to net8 as well?

I will do it in the next few days

@m3nax
m3nax marked this pull request as draft November 24, 2023 07:36
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2023
@m3nax m3nax changed the title Move examples to net8.0 Move to net8.0 Nov 24, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 24, 2023
@m3nax
m3nax marked this pull request as ready for review November 24, 2023 10:01
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2023
@m3nax

m3nax commented Nov 24, 2023

Copy link
Copy Markdown
Contributor Author

@tg123 Work done

@m3nax

m3nax commented Nov 24, 2023

Copy link
Copy Markdown
Contributor Author

/test ?

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@m3nax: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tg123

tg123 commented Nov 24, 2023

Copy link
Copy Markdown
Member

@m3nax

m3nax commented Nov 24, 2023

Copy link
Copy Markdown
Contributor Author

@tg123 Done

@tg123 tg123 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 24, 2023
@tg123

tg123 commented Nov 26, 2023

Copy link
Copy Markdown
Member

seems testcases need some upgrade

Expected: typeof(System.IO.IOException)
Actual:   typeof(System.Net.Http.HttpIOException)

@m3nax

m3nax commented Nov 27, 2023

Copy link
Copy Markdown
Contributor Author

seems testcases need some upgrade

Expected: typeof(System.IO.IOException)
Actual:   typeof(System.Net.Http.HttpIOException)

Yes but it is strange that with net 6/7 the exception is System.IO.IOException with 8 is System.Net.Http.HttpIOException, it is a breaking change

@tg123

tg123 commented Nov 27, 2023

Copy link
Copy Markdown
Member

catch HttpIOException | IOExcpetion?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2023
@m3nax

m3nax commented Nov 27, 2023

Copy link
Copy Markdown
Contributor Author
[xUnit.net 00:05:04.32]     Can exec in pod's default container, STDOUT only [FAIL]
  Failed Can exec in pod's default container, STDOUT only [11 s]
  Error Message:
   System.Threading.Tasks.TaskCanceledException : A task was canceled.
  Stack Trace:
     at System.Net.WebSockets.ManagedWebSocket.SendFrameFallbackAsync(MessageOpcode opcode, Boolean endOfMessage, Boolean disableCompression, ReadOnlyMemory`1 payloadBuffer, Task lockTask, CancellationToken cancellationToken)
   at k8s.Tests.WebSocketTestBase.SendMultiplexed(WebSocket webSocket, Byte streamIndex, String text) in /_/tests/KubernetesClient.Tests/WebSocketTestBase.cs:line 266
   at k8s.Tests.PodExecTests.ExecDefaultContainerStdOut() in /_/tests/KubernetesClient.Tests/PodExecTests.cs:line 85
--- End of stack trace from previous location ---
  Standard Output Messages:
 Invoking exec operation...
 Test-level cancellation token has been canceled.
 Client socket connected (socket state is Open). Waiting for server-side socket to become available...
 Server-side socket is now available (socket state is Open). Sending data to server socket...


Results File: D:\a\csharp\csharp\TestResults\runneradmin_fv-az742-628_2023-11-27_10_09_15.trx

Failed!  - Failed:     1, Passed:   189, Skipped:     2, Total:   192, Duration: 4 m 56 s - KubernetesClient.Tests.dll (net6.0)

Looks like we've hit the job timeout... Right?

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 1, 2023
@m3nax

m3nax commented Dec 1, 2023

Copy link
Copy Markdown
Contributor Author

@tg123 Why are the compilation and testing actions not started?

@tg123

tg123 commented Dec 1, 2023

Copy link
Copy Markdown
Member

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2023
@k8s-ci-robot
k8s-ci-robot merged commit 15ad5bd into kubernetes-client:master Dec 1, 2023
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: m3nax, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants