preserve style selectable precedence#76
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughThis PR reorders JSX attribute emission for Text components so ChangesText attribute ordering fix
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Nightly build on my fork failed: https://github.com/adamivancza/react-native-boost/actions/runs/28921814048
Fixes a parity fuzz divergence where static
style.userSelectdid not overrideselectablefrom a later spread.React Native Text applies
userSelectas a late style-derived override, so:should end up with
selectable={false}.Boost already handled the dynamic
processTextStyle(...)path this way, but the static build-timeselectableattribute was emitted too early and could be overwritten by later props/spreads.Changes
Verification
pnpm package test textpnpm package test paritySummary by CodeRabbit